-
Notifications
You must be signed in to change notification settings - Fork 121
[Shipping Labels] Split shipment initial UI #15397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the UI looks good in general. I left some nit-picking in the comments, but I'm approving the PR to avoid blocking development.
...WooShipping Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCard.swift
Show resolved
Hide resolved
...WooShipping Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCard.swift
Show resolved
Hide resolved
...ng Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCardViewModel.swift
Outdated
Show resolved
Hide resolved
...ng Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCardViewModel.swift
Outdated
Show resolved
Hide resolved
| BadgeView(text: viewModel.item.quantityLabel, | ||
| customizations: .init(textColor: .white, backgroundColor: .black), | ||
| backgroundShape: badgeStyle) | ||
| .offset(x: Layout.badgeOffset, y: -Layout.badgeOffset) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I see that this applies to the order creation screen as well. I logged an issue to keep track. #15402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be quickly fixed by adding stroke to the background view of the BadgeView with style roundedRectangle. But fixing it in a separate PR sounds good to me too.
...s/WooShipping Create Shipping Labels/WooShipping Split Shipments/SelectableShipmentRow.swift
Show resolved
Hide resolved
...WooShipping Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCard.swift
Outdated
Show resolved
Hide resolved
|
Thanks for the review and helpful suggestions, @itsmeichigo!
Please take another look at the PR when you can. Thanks! 🙇 |
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! The changes look good to me 👍
I left a comment in a previous thread about fixing the missing border for the badge, but it's ok to fix it later too.
I also found that Split shipment button is also available in an existing label, which I missed in a previous PR. Please feel free to fix it in a subsequent PR.
Thanks for the solution! Considering that this needs to be fixed on other screens with the badge as well, I will fix this in a separate PR.
Good catch. Logged a subtask in #15305 |

Part of: #15305
Description
Adds the initial UI for the split shipments screen.
Design
Internal - bsLNrhmi2xQZB4C0TzjmHB-fi-942_43007
Changes
The changes in this PR focus only on the UI. The selection logic will be added/altered in future PRs.
Steps to reproduce
Testing information
Validated that the expansion, collapse, and selection steps look as per the design.
Screenshots
Screenshots
Screen recording
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-23.at.16.14.05.mp4
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: