Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Mar 24, 2025

Closes: #15316
Also closes #15317
Also closes #15311

Description

This PR wraps up the HAZMAT functionality of the new shipping label flow:

  • Updated the HAZMAT detail view to display the currently selected category.
  • Added a button to save selection when disabling HAZMAT after selecting a category.

Steps to reproduce

  1. Log in to a test store with Woo Shipping plugin set up.
  2. Select a completed order with at least one physical product.
  3. Select Create shipping label > tap the HAZMAT row.
  4. Switch on HAZMAT then select any category.
  5. Tap the HAZMAT row again then confirm that the selected category is displayed correctly.
  6. Tap the pencil button and select a different category. Confirm that the HAZMAT detail view is dismissed and the new category is displayed on the creation form.
  7. Tap the HAZMAT row again then turn off HAZMAT using the toggle.
  8. Confirm that the Save button shows up at the bottom. Tap the button.
  9. Confirm that the HAZMAT detail view is dismissed and the creation form shows that no HAZMAT category is set. Confirm that the correct notice is displayed in this case.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 and confirm the above test cases.

Screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-24.at.15.04.16.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Mar 24, 2025
@itsmeichigo itsmeichigo added this to the 22.1 milestone Mar 24, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review March 24, 2025 08:13
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15405-f1ddaf0
Version22.0
Bundle IDcom.automattic.alpha.woocommerce
Commitf1ddaf0
App Center BuildWooCommerce - Prototype Builds #13389
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

This was linked to issues Mar 24, 2025
@selanthiraiyan selanthiraiyan self-assigned this Mar 24, 2025
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 🚀

Base automatically changed from task/15315-hazmat-selection to trunk March 25, 2025 03:13
@itsmeichigo itsmeichigo merged commit 0451803 into trunk Mar 25, 2025
25 checks passed
@itsmeichigo itsmeichigo deleted the task/15316-change-save-hazmat branch March 25, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hazmat] Turn off [Hazmat] Changing a category Hazmat

4 participants