Skip to content

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Mar 24, 2025

Closes: #15305

Description

Starts showing the instructions notice in the split shipments flow.

Changes

  • Alter Notice to work without a title.
  • Use BoldableTextView in Notice for showing markdown message.
  • Show instructions notice if there is no selection made in split shipments screen.
  • Shows "Split shipments" view only if a shipping label has not been purchased.

Steps to reproduce

  1. Log in to a test store with the Woo Shipping plugin set up.
  2. Create an order with multiple products and different quantities for each product.
  3. Enter a valid shipping address for the order.
  4. Open the order detail page.
  5. Tap "Create shipping label".
  6. Tap "Split shipments".
  7. Validate that you see a notice with instructions to select items to split into shipments. Design - bsLNrhmi2xQZB4C0TzjmHB-fi-942_42236
  8. Selecting any item should make that instructions notice disappear.

Testing information

Tested that the instructions notices is displayed as described above.

Screenshots

Purchased a shipping label

Before After
Before After

Notice for instructions

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-24.at.14.49.42.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Mar 24, 2025
@selanthiraiyan selanthiraiyan added this to the 22.1 milestone Mar 24, 2025
@selanthiraiyan selanthiraiyan marked this pull request as ready for review March 24, 2025 09:25
@itsmeichigo itsmeichigo self-assigned this Mar 24, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 24, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15406-44b4cea
Version22.0
Bundle IDcom.automattic.alpha.woocommerce
Commit44b4cea
App Center BuildWooCommerce - Prototype Builds #13392
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@selanthiraiyan selanthiraiyan merged commit 40f79ff into trunk Mar 24, 2025
13 checks passed
@selanthiraiyan selanthiraiyan deleted the task/15305-notice-to-select branch March 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Split shipment] Entering split shipment mode

4 participants