Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Mar 26, 2025

Description

This PR disables the allowMerchantAIAPIKey flag for the time being so it doesn’t render just an empty view in dev builds while we prioritize the project.

Testing information

  • Run the app
  • Go to menu
  • Observe how "AI settings" row does not appear.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

Let’s disable the flag for the time being so it doesn’t render an empty view in dev builds while we prioritize the project :D
@iamgabrielma iamgabrielma added feature: app settings Related to settings accessed via the gear icon in the My Store section. type: task An internally driven task. labels Mar 26, 2025
@iamgabrielma iamgabrielma added this to the 22.1 milestone Mar 26, 2025
@iamgabrielma iamgabrielma enabled auto-merge March 26, 2025 04:05
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15421-d8bf028
Version22.0
Bundle IDcom.automattic.alpha.woocommerce
Commitd8bf028
App Center BuildWooCommerce - Prototype Builds #13413
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@iamgabrielma iamgabrielma merged commit 19507c6 into trunk Mar 26, 2025
21 of 25 checks passed
@iamgabrielma iamgabrielma deleted the hack/disable-flag-in-dev-builds branch March 26, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: app settings Related to settings accessed via the gear icon in the My Store section. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants