Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Part of #15307

Description

This PR handles the renaming of shipment item rows and properties to avoid ambiguity when moving them to different shipments.

Steps to reproduce

There are only renaming, so please feel free to test #15418 again to ensure everything works correctly.

Testing information

Tested the shipment row on simulator iPhone 16 Pro iOS 18.2 and confirmed that the WIP still works correctly.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Mar 26, 2025
@itsmeichigo itsmeichigo added this to the 22.1 milestone Mar 26, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 26, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review March 26, 2025 05:30
@selanthiraiyan selanthiraiyan self-assigned this Mar 26, 2025
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. The renaming makes perfect sense. 🚀

@itsmeichigo itsmeichigo enabled auto-merge March 26, 2025 05:40
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15422-3c9155c
Version22.0
Bundle IDcom.automattic.alpha.woocommerce
Commit3c9155c
App Center BuildWooCommerce - Prototype Builds #13414
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo merged commit c5c3fce into trunk Mar 26, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the task/15307-shipment-renaming branch March 26, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants