-
Notifications
You must be signed in to change notification settings - Fork 121
Shipping Label: Rename views and properties for shipment items #15422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
selanthiraiyan
approved these changes
Mar 26, 2025
Contributor
selanthiraiyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. The renaming makes perfect sense. 🚀
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15307
Description
This PR handles the renaming of shipment item rows and properties to avoid ambiguity when moving them to different shipments.
Steps to reproduce
There are only renaming, so please feel free to test #15418 again to ensure everything works correctly.
Testing information
Tested the shipment row on simulator iPhone 16 Pro iOS 18.2 and confirmed that the WIP still works correctly.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: