[Woo POS][Products Search] Add POSProduct in Networking #15441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jaclync
approved these changes
Mar 28, 2025
Tested both WPCOM login and application password login, products were loaded as before including variable products!
Comment on lines
+3
to
+5
| /// ListMapper: Maps generic WooCommerce REST API Lists | ||
| /// | ||
| struct ListMapper<Output: Decodable>: Mapper { |
There was a problem hiding this comment.
👏 no more copying mapper for new use case! We can create an issue to replace existing mappers and let the mobile team know.
| @@ -102,7 +102,7 @@ public final class PointOfSaleItemService: PointOfSaleItemServiceProtocol { | |||
| // Maps result to POSItem, and populate the output with: | |||
| // - Formatted price based on store's currency settings. | |||
| // - Product thumbnail, if any. | |||
| private func mapProductsToPOSItems(products: [Product]) -> [POSItem] { | |||
| private func mapProductsToPOSItems(products: [POSProduct]) -> [POSItem] { | |||
There was a problem hiding this comment.
Nice that this is the only change in POS 👍
| @@ -202,11 +202,11 @@ public final class ProductsRemote: Remote, ProductsRemoteProtocol { | |||
| /// - Parameters: | |||
| /// - siteID: Site for which we'll fetch remote products. | |||
| /// - productTypes: A list of product types to be included in the results. | |||
| /// - pageNumber: Number of page that should be retrieved. | |||
| /// - pageNumber: Number of pages that should be retrieved. | |||
There was a problem hiding this comment.
nit: I think this parameter is the page index (starting with 1), not the number of pages (total page count)?
There was a problem hiding this comment.
Yep, you're absolutely right! I was obviously not thinking straight, I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15439
Description
Adds a
POSProductmodel and updates theProductsRemote.loadProductsForPointOfSalefunction to use it.Adds a generic
ListMapperwhich can be used for mapping any standard list from the REST API – however it's only used forPOSProductat this point.We decided to make a new copy of Product for Point of Sale to support the future persistence of the product catalogue: pdfdoF-6Ha-p2#comment-7880, pdfdoF-6Pb-p2. This version of the Product will only contain what we need for Point of Sale.
Steps to reproduce
Testing information
I've tested with both site credentials and Jetpack – the mapping behaviour is slightly different between the two as only the Jetpack-tunnelled version of the API response is wrapped in a
dataenvelope.I checked that we could load multiple pages, reload, create orders, edit orders, and use variable products the same as previously.
I've also checked that the existing Orders and Products features work correctly.
I've tested on an iPad Air running iPadOS 17.7.3, and a simulator running iPadOS 18.2.
Screenshots
POSProduct.in.use.mp4
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: