[Login] Use magic link for suspicious emails #15444

hichamboushaba · 2025-03-27T22:44:52Z

Description

This PR implements the first part of the project, updating the suspicious email flow to use magic links in the login.

In my spike initially, I suggested reusing the screen LoginLinkRequestViewController, but when working on this, I found out that this screen is not part of the unified login flow, so I added a new screen, and I matched its design to the Android one.

Steps to reproduce

TC1: Confirming navigation to magic link request screen

Open the app.
Enter the address of a Jetpack connected site
Enter the email address shared here 37602-pb
Make sure to not send the magic link.

For all the following TCs, apply the following patch

TC2: Magic Link login flow

Open the app
Enter the address of a Jetpack connected site.
Enter an address email that can receive magic links
Tap on Send email in the next screen.

TC3: Fallback to username/password

Open the app
Enter the address of a Jetpack connected site.
Enter an address email that can receive magic links
Tap on Use username and password instead.
Sign in using site credentials.

Testing information

TC1: Confirm that the app shows the Magic Link request screen.

TC2: Confirm that the email was sent, and that the following was tracked:

🔵 Tracked unified_login_step, properties: [flow: login_magic_link, step: start, source: default]
🔵 Tracked login_magic_link_request_form_viewed
🔵 Tracked unified_login_interaction, properties: [source: default, flow: login_magic_link, step: start, click: request_magic_link]
🔵 Tracked unified_login_step, properties: [source: default, step: magic_link_auto_requested, flow: login_magic_link]

TC3: Confirm that signing using site credentials work, and that the following was tracked after tapping on the fallback button:

Tracked unified_login_step, properties: [flow: login_magic_link, source: default, step: start]
🔵 Tracked login_magic_link_request_form_viewed
🔵 Tracked unified_login_interaction, properties: [click: login_with_wp_com_username_password, source: default, step: start, flow: login_magic_link]

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-28.at.01.56.28.mp4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

coderabbitai · 2025-03-27T22:44:58Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dangermattic · 2025-03-27T23:06:44Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-03-27T23:17:08Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`29020`
	Version	`PR #15444`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`e033e5f`
	Installation URL	6df3atnrh0m68

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

hichamboushaba · 2025-03-28T02:00:57Z

.../WordPressAuthenticator/Unified Auth/View Related/Login/MagicLinkRequestViewController.swift

+
+// MARK: UI Setup
+private extension MagicLinkRequestViewController {
+    private func configureStackView() {


I didn't use a xib file, as I still don't feel familiar with XCode UI for them, and I didn't use SwiftUI just to make sure the content is correctly styled to match the other screens. If you have any remarks about this please share them.

selanthiraiyan

Thanks for working on this, Hicham! Great job navigating through the authenticator library code. 👏

I have a the following questions about the UI before approving this PR.

Would the wording "store credentials" in the above screen create confusion about where to enter their store's wporg credentials or WPCOM username and password?
I see that we pre-fill the email in the above screen. AFAIK, logging in using WPCOM email and password will not work for a suspicious email. Should we avoid pre-filling the email.

The title of "Use username and password instead" button isn't fully visible while using large fonts.

selanthiraiyan · 2025-03-31T02:14:38Z

.../WordPressAuthenticator/Unified Auth/View Related/Login/MagicLinkRequestViewController.swift

+        )
+    }
+
+    private func fallbackButtonTitle() -> String {


Suggested change

private func fallbackButtonTitle() -> String {

func fallbackButtonTitle() -> String {

nit: This method is already inside a private extension.

selanthiraiyan · 2025-03-31T02:15:28Z

.../WordPressAuthenticator/Unified Auth/View Related/Login/MagicLinkRequestViewController.swift

+        pinSubviewToHorizontalEdges(primaryButton)
+    }
+
+    private func createHeader() -> UIView {


nit: We can remote the private keyword as this method is already inside a private extension. Applies to other methods inside this extension.

selanthiraiyan · 2025-03-31T02:16:46Z

.../WordPressAuthenticator/Unified Auth/View Related/Login/MagicLinkRequestViewController.swift

+    private func createHeader() -> UIView {
+        let headerStackView = UIStackView()
+        headerStackView.spacing = 16
+        headerStackView.layoutMargins = UIEdgeInsets(top: 24, left: 16, bottom: 24, right: 16)


I suggest moving the spacing and padding related constants used in this view inside a Layout enum like we follow in SwiftUI views. WDYT?

hichamboushaba added type: enhancement A request for an enhancement. feature: login Related to any part of the log in or sign in flow, or authentication. labels Mar 27, 2025

hichamboushaba force-pushed the issue/14878-login-suspicious-email-p1 branch from 7eecc65 to 1102b53 Compare March 28, 2025 01:47

hichamboushaba added 7 commits March 28, 2025 01:58

Add a new screen for requesting magic links

6ad5374

Allow specifying the fallback button type

34791fe

Handle navigation to fallback screens

bc9fdf7

Fix username/password login to wordpress.com

d23499e

Move logic to separate function

f52b0f5

Handle requesting magic link and navigation

0176033

Align button text on magic link sent screen

6274d23

hichamboushaba force-pushed the issue/14878-login-suspicious-email-p1 branch from 1102b53 to f3ea590 Compare March 28, 2025 01:59

hichamboushaba commented Mar 28, 2025

View reviewed changes

hichamboushaba added this to the 22.1 milestone Mar 28, 2025

hichamboushaba added 2 commits March 28, 2025 02:03

Add tracking

34df201

Add release note

e033e5f

hichamboushaba force-pushed the issue/14878-login-suspicious-email-p1 branch from f3ea590 to e033e5f Compare March 28, 2025 02:03

hichamboushaba requested review from itsmeichigo and selanthiraiyan March 28, 2025 02:04

hichamboushaba marked this pull request as ready for review March 28, 2025 02:04

selanthiraiyan self-assigned this Mar 28, 2025

selanthiraiyan reviewed Mar 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Login] Use magic link for suspicious emails #15444

[Login] Use magic link for suspicious emails #15444

hichamboushaba commented Mar 27, 2025 •

edited

Loading

coderabbitai bot commented Mar 27, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

dangermattic commented Mar 27, 2025 •

edited

Loading

wpmobilebot commented Mar 27, 2025 •

edited

Loading

hichamboushaba Mar 28, 2025

selanthiraiyan left a comment

selanthiraiyan Mar 31, 2025

selanthiraiyan Mar 31, 2025

selanthiraiyan Mar 31, 2025

	private func fallbackButtonTitle() -> String {
	func fallbackButtonTitle() -> String {

[Login] Use magic link for suspicious emails #15444

Are you sure you want to change the base?

[Login] Use magic link for suspicious emails #15444

Conversation

hichamboushaba commented Mar 27, 2025 • edited Loading

Description

Steps to reproduce

Testing information

Screenshots

Reviewer (or Author, in the case of optional code reviews):

coderabbitai bot commented Mar 27, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

dangermattic commented Mar 27, 2025 • edited Loading

wpmobilebot commented Mar 27, 2025 • edited Loading

hichamboushaba Mar 28, 2025

Choose a reason for hiding this comment

selanthiraiyan left a comment

Choose a reason for hiding this comment

selanthiraiyan Mar 31, 2025

Choose a reason for hiding this comment

selanthiraiyan Mar 31, 2025

Choose a reason for hiding this comment

selanthiraiyan Mar 31, 2025

Choose a reason for hiding this comment

hichamboushaba commented Mar 27, 2025 •

edited

Loading

dangermattic commented Mar 27, 2025 •

edited

Loading

wpmobilebot commented Mar 27, 2025 •

edited

Loading