Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Labels] Update shipment endpoint - Networking layer #15445

Merged
merged 9 commits into from
Mar 28, 2025

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Mar 28, 2025

Part of: #15308

Description

Adds support for updating shipments in the networking layer.

Changes

  • New method in WooShippingRemote to support updating shipments.
  • Model files to send shipments and parse response.
  • Mapper and mock json files.
  • Unit tests.

Steps to reproduce

This endpoint isn't used yet. Unit tests should pass.

Testing information

NA

Screenshots

NA


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Mar 28, 2025
@selanthiraiyan selanthiraiyan added this to the 22.1 milestone Mar 28, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29024
VersionPR #15445
Bundle IDcom.automattic.alpha.woocommerce
Commit42fa5d3
Installation URL5g20daj8ug7g0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@selanthiraiyan selanthiraiyan marked this pull request as ready for review March 28, 2025 06:34
@itsmeichigo itsmeichigo self-assigned this Mar 28, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@selanthiraiyan selanthiraiyan merged commit 6b65106 into trunk Mar 28, 2025
16 checks passed
@selanthiraiyan selanthiraiyan deleted the task/15308-create-shipment-network branch March 28, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants