Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Jun 13, 2025

Description

This PR re-enables the CardReaderConnectionControllerTests, which were previously disabled for failing in CI.

Xcode changes seem to have fixed this for us. I verified by running the suite 50 times in CI, it passed for all of them.

I took the opportunity to fix up some small issues with the related mocks – none of these made any difference to how the tests run.

Steps to reproduce

Check all tests run and pass in CI


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 13, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30450
VersionPR #15749
Bundle IDcom.automattic.alpha.woocommerce
Commit1fd2921
Installation URL5qtke3ououv5g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald added type: task An internally driven task. Testing labels Jun 13, 2025
@joshheald joshheald added this to the 22.7 milestone Jun 13, 2025
@joshheald joshheald marked this pull request as ready for review June 13, 2025 16:23
@joshheald joshheald requested a review from iamgabrielma June 13, 2025 16:24
@iamgabrielma iamgabrielma self-assigned this Jun 16, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I verified by running the suite 50 times in CI, it passed for all of them.

Nice trick!

@joshheald joshheald merged commit 222fc6f into trunk Jun 16, 2025
25 checks passed
@joshheald joshheald deleted the woomob-83-mobile-payments-review-cardreaderconnectioncontrollertests branch June 16, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants