Re-enable connection controller tests #15749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
This PR re-enables the
CardReaderConnectionControllerTests, which were previously disabled for failing in CI.Xcode changes seem to have fixed this for us. I verified by running the suite 50 times in CI, it passed for all of them.
I took the opportunity to fix up some small issues with the related mocks – none of these made any difference to how the tests run.
Steps to reproduce
Check all tests run and pass in CI
RELEASE-NOTES.txtif necessary.