Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jun 16, 2025

Closes WOOMOB-613

Description

This PR cleans up the enableCouponsInPointOfSale feature flag.

Testing information

In POS ( now in a new tab!) there should be no changes in rendering the Coupons navigation, "create coupon" button, or display coupons in the cart. The checkout button should still only work when items have been added to cart, not only coupons.

Will clean up search separately to keep things encapsulated, or we can do it here as well. Whatever you prefer 🙇

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: coupons Related to basic fulfillment such as order tracking. feature: POS labels Jun 16, 2025
@iamgabrielma iamgabrielma added this to the 22.7 milestone Jun 16, 2025
@iamgabrielma iamgabrielma requested a review from staskus June 16, 2025 06:24
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up, @iamgabrielma!

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30454
VersionPR #15751
Bundle IDcom.automattic.alpha.woocommerce
Commit81f390c
Installation URL3r5ri8p2u7nl8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma merged commit c622e18 into trunk Jun 16, 2025
24 of 27 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-613-remove-enableCouponsInPointOfSale-flag branch June 16, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: coupons Related to basic fulfillment such as order tracking. feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants