Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

Description

This PR removes the usage of the unused domain-credit image as part of reducing the app size on WOOMOB-534. After checking with Kiwi folks it seems we no longer have an entry point for the domain purchase feature as a whole ( #15680 ), so I took the opportunity to clean up the related code as well.

I've only removed the code directly coupled with the feature, happy to remove the rest in this same PR (there's still files remaining under the /domains folder as well as 2 test suites that we might not need to run anymore).

Testing information

  • CI should pass
  • From my understanding of this feature, we should still see no Domains row under Menu tab > Settings, on a WPCom test store without a custom domain, and no other entry points or access to the deleted files since the DomainSettingsCoordinator is out of the settings controller, but let me know if I missed something.

@iamgabrielma iamgabrielma requested a review from itsmeichigo June 16, 2025 08:54
@iamgabrielma iamgabrielma added type: task An internally driven task. feature: app settings Related to settings accessed via the gear icon in the My Store section. labels Jun 16, 2025
@iamgabrielma iamgabrielma added this to the 22.7 milestone Jun 16, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 16, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30510
VersionPR #15754
Bundle IDcom.automattic.alpha.woocommerce
Commitcd47709
Installation URL26f4jfbfk9es0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Jun 17, 2025
@itsmeichigo
Copy link
Contributor

Hi @iamgabrielma - could you please remove all the domain folder and tests? I don't think keeping them around is useful.

@iamgabrielma
Copy link
Contributor Author

Hi @iamgabrielma - could you please remove all the domain folder and tests? I don't think keeping them around is useful.

No problem! I've removed the domain folder and tests from the woo layer, but there's still dead code in Yosemite and Networking. This can be handled separately, as this PR is already close to 3k lines 👍

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the assets and dead code for the domain feature. We've removed the entry points from both Settings and Store onboarding dashboard card so it's good to remove all the code now.

@iamgabrielma iamgabrielma merged commit b6c2f01 into trunk Jun 17, 2025
13 checks passed
@iamgabrielma iamgabrielma deleted the task/part-of-WOOMOB-534-remove-domain-credit-ref branch June 17, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: app settings Related to settings accessed via the gear icon in the My Store section. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants