Skip to content

Remove a few dead references and no longer used files #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Remove a few dead references and no longer used files #15762

merged 2 commits into from
Jun 17, 2025

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 17, 2025

Stumbled on these while working on #15737 and beyond.

If CI is green, we should be good to merge.

@mokagio mokagio added this to the 22.7 milestone Jun 17, 2025
@mokagio mokagio self-assigned this Jun 17, 2025
@mokagio mokagio added the type: technical debt Represents or solves tech debt of the project. label Jun 17, 2025
@mokagio mokagio enabled auto-merge June 17, 2025 04:31
mokagio
mokagio commented Jun 17, 2025
View reviewed changes
WooCommerce/WooCommerce.xcodeproj/project.pbxproj
Comment on lines -1219 to +1220
2D88C1112DF883C300A6FB2C /* AttributedString+Helpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2D88C1102DF883BD00A6FB2C /* AttributedString+Helpers.swift */; };
2D880B492DFB2F3F00A6FB2C /* OptionalBinding.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2D880B482DFB2F3D00A6FB2C /* OptionalBinding.swift */; };
2D88C1112DF883C300A6FB2C /* AttributedString+Helpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2D88C1102DF883BD00A6FB2C /* AttributedString+Helpers.swift */; };
Copy link
Contributor Author

@mokagio mokagio Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice these two lines are the same file being moved by Xcode in the list. Not a new file.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 17, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30494
VersionPR #15762
Bundle IDcom.automattic.alpha.woocommerce
Commit93af56e
Installation URL2lv208o92sve0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio requested review from a team June 17, 2025 05:53
staskus
staskus approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@mokagio mokagio merged commit dd582a6 into trunk Jun 17, 2025
18 checks passed
@mokagio mokagio deleted the mokagio/cleanup-20250617 branch June 17, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

Assignees

@mokagio mokagio

Labels

type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Milestone

22.7

Development

Successfully merging this pull request may close these issues.

4 participants

@mokagio @wpmobilebot @staskus