AINFRA-780 - Make NetworkingTests a Swift package test target

[mokagio]

Description

Now that all the frameworks sources are Swift packages (targets in the same Swift package to be precise) we can move the tests there, too. We didn't do that all in one go to avoid big diffs.

Notice:

• The whole Networking/ folder has been removed, including the dedicated Xcode project
• No changes in the test code
• The Yosemite and WooCommerce test targets now reference the NetworkingTests/Responses/ folder from the location in the Modules/Tests/ folder. At some point, we ought to isolate the responses in some kind of tests helper package, but for the moment including them this way (which to me is like a soft-duplication) is convenient.

Testing information

See green CI.

Additionally, you can run the focused Hardware tests by selecting the Hardware scheme from Xcode.

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. — N.A.

[dangermattic]

	2 Warnings
⚠️	Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30704
	Version	PR #15796
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	8ca4a18
	Installation URL	039h07t08vapo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jaclync]

Thanks for the changes! I removed the derived data and tried running the remote tests locally, some behaviors I'd like to clarify:

1. There's still a Networking project in the project navigator, but clicking on shows an error (first screenshot). Also seeing an error (the second screenshot) that doesn't block running the tests but I think it's worth removing to reduce confusion:

error clicking on Networking project	similar error

2. In order to run Networking tests, is it an expected change to have to switch to the Networking scheme instead of staying in the WooCommerce scheme?

3. I haven't been able to see the diamond check boxes next to each test class/function in the code to run them, do they show up on your end? Just wondering if it is an unexpected change, if so it might be worth notifying developers to prevent from unncessary time trying to get them working. I tried reopening Xcode which usually resolves it, but still cannot see them appear.

branch	trunk

[jaclync]

• The Yosemite and WooCommerce test targets now reference the NetworkingTests/Responses/ folder from the location in the Modules/Tests/ folder. At some point, we ought to isolate the responses in some kind of tests helper package, but for the moment including them this way (which to me is like a soft-duplication) is convenient.

I agree that a separate package for these mock responses would be ideal.

[mokagio]

Thanks for the review @jaclync 🙇‍♂️

1. There's still a Networking project in the project navigator...

Ouch! I should have double checked and removed it from the workspace. I rebased on trunk to address a merge conflict and also addressed that.

2. In order to run Networking tests, is it an expected change to have to switch to the Networking scheme instead of staying in the WooCommerce scheme?

No. That's just Xcode being annoying with the test plan and rebase. See for example https://github.com/woocommerce/woocommerce-ios/pull/15794/files#r2160527954. This should be addressed now as well.

3. I haven't been able to see the diamond check boxes next to each test class/function in the code to run them, do they show up on your end?

Funny that you mention that. It's a long standing Xcode bug which should be fixed in Xcode 26:

[jaclync]

Thanks for the updates! 1 is fixed now, and 3 doesn't sound like a blocking issue and should be fixed later.

2. In order to run Networking tests, is it an expected change to have to switch to the Networking scheme instead of staying in the WooCommerce scheme?

No. That's just Xcode being annoying with the test plan and rebase. See for example https://github.com/woocommerce/woocommerce-ios/pull/15794/files#r2160527954. This should be addressed now as well.

After rebasing the PR and relaunching Xcode a few times, I still wasn't able to run the NetworkingTests with the WooCommerce scheme.

More importantly, I didn't seem to find the NetworkingTests (and StorageTests which is also missing from the screenshot above) mentions in the unit tests CI logs. Not sure if I missed the tests in the CI logs?

[mokagio]

@jaclync Mmmm.... What's going on? The two targets weren't there on my branch after rebasing on trunk either. But that's very odd given the screenshot above, which I took on purpose to show they worked when I pushed.

Anyway, I committed the Test Plan update in isolation in 93ec55a.

Let's see how it goes in CI this time.

[iamgabrielma]

👀 Just sneaking in this PR to share that CI failed with the crash I originally saw when making StorageTests a package, so we might have some flakiness here:

🔬 Unit Tests: 1 tests have failed (1 distinct assertion failure(s) in total)
test_file_is_loaded() in FileStorageTests
Crash: xctest (2683) implicit closure #1 in FileStorageTests.test_file_is_loaded()

I haven't re-run the failing build in case you want to take a further look 👍

[mokagio]

@jaclync @iamgabrielma thanks folks.

Everything should be fixed now. I clearly lost something along the way with the rebases 😓

[jaclync]

Thanks for the updates @mokagio! I see the NetworkingTests in the latest CI log, can run NetworkingTests without switching scheme as the NetworkingTests is included in the test plan now.