Skip to content

Add build phase script to remove Wormholy files #15804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+39 −7
Closed

Add build phase script to remove Wormholy files #15804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84f472
Add build phase run script to remove Wormholy from release builds
mokagio Jun 24, 2025
ea3e407
HACK to test removal on debug and prototype builds
mokagio Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Scripts/build-phases/strip-wormholy-from-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#!/bin/bash -eu

if [ "${CONFIGURATION}" != "Release" ]; then
echo "info: Skipping Wormholy removal – not a Release build."
exit 0
fi
# if [ "${CONFIGURATION}" != "Release" ]; then
# echo "info: Skipping Wormholy removal – not a Release build."
# exit 0
# fi

# FIXME: Delete from all builds to test the implementation
Copy link
Contributor Author

@mokagio mokagio Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we should remove the comments before merging.


BUILT_PRODUCTS_DIR=${BUILT_PRODUCTS_DIR:-"$TARGET_BUILD_DIR"}

Expand Down
14 changes: 7 additions & 7 deletions WooCommerce/Classes/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ import class Yosemite.ScreenshotStoresManager
// In that way, Inject will be available in the entire target.
@_exported import Inject

#if DEBUG
import WormholySwift
#endif
//#if DEBUG
Copy link
Contributor

@iangmaia iangmaia Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say something about trying condition: .when(configuration: .debug) but just seen this discussion 😞

SwiftPM allows conditional platform dependencies, but not conditional configurations.

//import WormholySwift
//#endif

// MARK: - Woo's App Delegate!
//
Expand Down Expand Up @@ -415,10 +415,10 @@ private extension AppDelegate {
/// Set up Wormholy only in Debug build configuration
///
func setupWormholy() {
#if DEBUG
// We want to activate it programmatically, not using the shake.
Wormholy.shakeEnabled = false
#endif
//#if DEBUG
// // We want to activate it programmatically, not using the shake.
// Wormholy.shakeEnabled = false
//#endif
}

/// Set up `KeyboardStateProvider`
Expand Down