[POS as a tab i2] Enable POS tab for stores in eligible countries behind i2 feature flag

[jaclync]

Closes WOOMOB-575

Just one reviewer is required.

Description

• Add checkVisibility() method to POSEntryPointEligibilityCheckerProtocol now that the tab visibility is different from POS eligibility for i2
• Implement different visibility logic based on pointOfSaleAsATabi2 feature flag:
  • When i2 enabled: only check country/currency and remote feature flag
  • When i2 disabled: use existing checkEligibility() logic
• Add test coverage for the new visibility method

Steps to reproduce

Prerequisite: a WPCOM account with at least two stores where one store is eligible for POS, and the other in a country that is not eligible for POS (e.g. CA)

• Log in to the store eligible for POS in the prerequisite --> the POS tab should be shown shortly
• Tap on the POS tab --> POS should be launched as before
• In wp-admin of this store, update the currency in WC settings to an eligible value
• Relaunch the app --> the POS tab should still be shown even after a while
• Tap on the POS tab --> POS should be launched as before. in a future task, a loading & eligible UI will be shown
• Go to the Menu tab and switch to the store in a country ineligible for POS --> the POS tab should not be shown even after a while
• Relaunch the app --> the POS tab should not be shown even after a while

Testing information

• @jaclync verifies behavior with both i2 feature flag states

Example screenshots

For a store in an eligible country but ineligible for other reason (e.g. currency):

i2 feature flag enabled	i2 feature flag disabled

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30881
	Version	PR #15824
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	1e2dcac
	Installation URL	64mdngbbcbg10

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[staskus]

Thanks! Works well 👍

[staskus]

As I understand, it's intentional to show POS option with unsupported currency for i2?

[jaclync]

Yup, as in the delivery plan pdfdoF-7po-p2, we're enabling the POS tab for all stores in eligible countries (US and UK for now).

[staskus]

I don't see much difference between is_ineligible_when_currency_is_not_supported and is_ineligible_when_country_is_not_supported tests. They both end up verifying the same condition .ineligible(reason: .unsupportedCountry))

[jaclync]

For the eligibility check (not the visibility check), the ineligible reason is different in these two test cases. is_ineligible_when_currency_is_not_supported takes in eligible countries but mismatching currency code and results in .ineligible(reason: .unsupportedCurrency), while is_ineligible_when_country_is_not_supported takes in ineligible countries and results in .ineligible(reason: .unsupportedCountry). Please let me know if I misunderstood anything.

[staskus]

Thanks for explaining, sorry, it's my mistake. For some reason, I read that both .ineligible results in unsupportedCountry, but that's not the case.

[jaclync]

Enabling auto-merge now, if anything actionable comes up I will address them separately.