Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jun 30, 2025

Closes WOOMOB-702

Description

This PR updates core data with a new model version 123, which adds the createdVia attribute to the Order model. This will be needed as part of POS Orders to persist the value of created_via that we receive from the API in order to set orders created via specific sources.

We're already parsing this value in OrdersRemote as OrderCreationSource, but at the moment we're not doing anything with it.

Testing information

No usage of the property yet, the app should run when opened, and freshly installed (no crashes due to core data migrations). CI should pass.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: order details Related to order details. feature: POS labels Jun 30, 2025
@iamgabrielma iamgabrielma added this to the 22.8 milestone Jun 30, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review June 30, 2025 03:57
@iamgabrielma iamgabrielma requested a review from itsmeichigo June 30, 2025 03:57
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma requested a review from staskus June 30, 2025 03:57
@iamgabrielma
Copy link
Contributor Author

👋 only one review is needed, added folks from different teams just because core data

@iamgabrielma iamgabrielma changed the title [POSOrders] Add createdVia attribute to Order data model, and migrate to model 123 [POS Orders] Add createdVia attribute to Order data model, and migrate to model 123 Jun 30, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30861
VersionPR #15836
Bundle IDcom.automattic.alpha.woocommerce
Commit98aafbd
Installation URL0hqd3omtffic0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Jun 30, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the app builds successfully.

@iamgabrielma iamgabrielma merged commit ba17aea into trunk Jun 30, 2025
29 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-702-add-createdvia-prop-to-cd-model branch June 30, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order details Related to order details. feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants