[POS Orders] Display POS badge in Order List #15839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
changed the base branch from
trunk
to
task/WOOMOB-700-POSOrders-feature-flag-i1
iamgabrielma
added
type: task
iamgabrielma
commented
Jun 30, 2025
| salesChannelLabel.applySalesChannelStyle() | ||
| salesChannelLabel.text = viewModel.salesChannel | ||
| } else { | ||
| salesChannelLabel.isHidden = true |
Contributor
Author
There was a problem hiding this comment.
I'm using isHidden here so we don't need to delete the placeholder from the .xib file, otherwise would show up anyway despite being unset, and I prefer to have it display in the .xib editor instead.
Collaborator
|
|
Base automatically changed from
task/WOOMOB-700-POSOrders-feature-flag-i1
to
trunk
June 30, 2025 12:34
staskus
approved these changes
Jun 30, 2025
Contributor
staskus
left a comment
staskus
left a comment
There was a problem hiding this comment.
👍 Oh, good old .xib files. I opened them to check, looks good, the changes shouldn't create any regressions. Testing also went well.
Contributor
Author
I "was born" directly into SwiftUI, I cannot tell you how long took me to make this simple change 😂 PD: Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-706
Description
This PR adds a new label to the
OrderTableViewCell.xib file and the order list configuration as preparatory work for POS Orders.We have no designs for these labels yet, so I went ahead with copying the same type we use for order statuses. "POS" is currently hardcoded and will show for all orders (behind a feature flag), the logic to display sales channel will be tackled later so it shows only when appropriate.
Testing information
pointOfSaleOrdersi1feature flag totruepointOfSaleOrdersi1feature flag tofalse. There should be no trace of the new label.Screenshots