Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

WOOMOB-617

Description

This is a follow up PR to fix remaining accessibility layout issues listed in doc: 1nxDAV51DK_l8opZ2ZznqaA3FpfiYPoWZPd38HA4TTys-gdoc

  • Fixes the issue where "Missing information" notice + CTA button footer take too much vertical space when bigger accessibility font size is toggled. The notice and button footer content is extracted and conditionally placed in bottom safe are for normal font sizes and embedded into general scrolling container in case of bigger accessibility font size
  • Fixes the issue where the destination address cell content was messed up for bigger font sizes. The content was redistributed vertically using AdaptiveStackVIew.
  • Fixes the weird layout for empty state in "Carrier" and "Saved" package selection tabs. Text and button label made multiline.
  • In split shipments view the the instruction notice and "selected" action pill were taking up too much space when bigger accessibility fonts were enabled. To fix that the notice + pill content was conditionally embedded into outer scrolling container.
  • Fixed the issue with the stale keyboard "prev/next + done" accessory toolbar. Re-arranged .toolbar and .sheet modifiers so the toolbar items were applied to views only where if was needed.

Testing steps

Consider testing on iOS Simulator for easier font size toggling.

  • Go to a completed order with an unfulfilled shipment.
  • Start editing the destination address. Delete information from one of required fields.
  • Make sure the "Missing information" notice label is presented above bottom cta button.
  • Scroll the sheet content and make sure the notice and the CTA button are attached to the bottom.
  • Increase the font size up to max.
  • Make sure the notice and CTA button are moved to the scroll view content bottom.
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.33.36.mov
  • Go to a completed order with an unfulfilled shipment.
  • Expand the "Shipment details" bottom sheet.
  • Increase the font size up to max.
  • Make sure the "Ship to" section content is vertically redistributed for larger fonts and looks OK.
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.37.42.mov
  • For the package empty state checking I suggest to adjust code a bit:
    • Comment out the following lines in WooCarrierPackagesSelectionView.swift
    self.carrierPackages = carrierPackages
    self.carrierTabs = carrierTabs
    
    • Return false for hasSavedPackages in WooSavedPackagesSelectionView.swift
  • Go to a completed order with an unfulfilled shipment.
  • Navigate to a package selection
  • For "Carrier" and "Saved" sections make sure the empty state content (label + button) are properly scaled for bigger fonts and don't have truncated wording.
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.45.01.mov
  • Go to a completed order with an unfulfilled shipment.
  • Tap on "pencil" to start editing existing shipment (Split shipments)
  • Select the unfulfilled shipment.
  • Select an item.
  • Make sure the instructions toast and the "N selected + move to" action pill is displayed.
  • Make sure the instructions and action pill are attached to bottom.
  • Increase the font size up to max.
  • Make sure the content is properly scaled.
  • Make sure the instructions and action pill are moved to the parent scrolling container for bigger accessibility font sizes.
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.52.14.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 22.8 milestone Jun 30, 2025
@RafaelKayumov RafaelKayumov added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jun 30, 2025
@RafaelKayumov RafaelKayumov force-pushed the WOOMOB-617-remaining-accessibility-layout-issues branch from ba85163 to 3b8d7cc Compare June 30, 2025 17:00
@RafaelKayumov RafaelKayumov marked this pull request as ready for review June 30, 2025 17:00
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 30, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30903
VersionPR #15844
Bundle IDcom.automattic.alpha.woocommerce
Commit36c47d5
Installation URL0n4ce20n51pdo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Jul 1, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the fixes!

I pushed some commits to further improve some issues:

  • Made the shipment to remove row expand to all horizontal space in 221ce72:
  • Applied the same fix in Ship to row to Ship from:
Before After
  • Make the empty state views in package tabs to be scrollable in b9bf7a0 and hide the add package button in empty states in 36c47d5:
Before After

@RafaelKayumov
Copy link
Contributor Author

@itsmeichigo Thx for the additions. Merging.

@RafaelKayumov RafaelKayumov merged commit 591d97d into trunk Jul 1, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-617-remaining-accessibility-layout-issues branch July 1, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants