-
Notifications
You must be signed in to change notification settings - Fork 121
[Shipping Labels] Remaining accessibility layout issues #15844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RafaelKayumov
merged 10 commits into
trunk
from
WOOMOB-617-remaining-accessibility-layout-issues
Jul 1, 2025
Merged
[Shipping Labels] Remaining accessibility layout issues #15844
RafaelKayumov
merged 10 commits into
trunk
from
WOOMOB-617-remaining-accessibility-layout-issues
Jul 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba85163 to
3b8d7cc
Compare
Collaborator
|
|
itsmeichigo
approved these changes
Jul 1, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the fixes!
I pushed some commits to further improve some issues:
- Made the shipment to remove row expand to all horizontal space in 221ce72:
- Applied the same fix in Ship to row to Ship from:
| Before | After |
|---|---|
![]() |
![]() |
- Make the empty state views in package tabs to be scrollable in b9bf7a0 and hide the add package button in empty states in 36c47d5:
| Before | After |
|---|---|
![]() |
![]() |
Contributor
Author
|
@itsmeichigo Thx for the additions. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





WOOMOB-617
Description
This is a follow up PR to fix remaining accessibility layout issues listed in doc: 1nxDAV51DK_l8opZ2ZznqaA3FpfiYPoWZPd38HA4TTys-gdoc
AdaptiveStackVIew..toolbarand.sheetmodifiers so the toolbar items were applied to views only where if was needed.Testing steps
Consider testing on iOS Simulator for easier font size toggling.
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.33.36.mov
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.37.42.mov
WooCarrierPackagesSelectionView.swiftfalseforhasSavedPackagesinWooSavedPackagesSelectionView.swiftSimulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.45.01.mov
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-30.at.19.52.14.mov
RELEASE-NOTES.txtif necessary.