POSTabEligibilityCheckerI2: i2 logic

[jaclync]

Part 2 of WOOMOB-756

Just one review is required.

⚠️ Please only review this PR if the base PR #15864 is approved without a need for significant changes.

Apology for the large diffs, the test file is ~670 diffs with some duplication of the test helpers. When pointOfSaleAsATabi2 feature flag is removed, POSTabEligibilityCheckerI2 and POSTabEligibilityCheckerI2Tests will replace POSTabEligibilityChecker and POSTabEligibilityCheckerTests.

Description

A recap of the differences between i1 and i2:

milestone	POS tab visibility check	POS eligibility check
i1	all conditions: tablet, iOS 17+, store country, store currency, remote feature flag, WC plugin version, POS feature switch for WC version 10.0+	none
i2	tablet, store country, remote feature flag	iOS 17+, store currency, WC plugin version, POS feature switch for WC version 10.0+

As the base PR #15864 updated POSTabEligibilityChecker and POSTabEligibilityCheckerTests to be i1 only, this PR adds POSTabEligibilityCheckerI2 and POSTabEligibilityCheckerI2Tests for the i2 implementation.

• POSTabEligibilityCheckerI2: the visibility & eligibility checks should only check for the conditions in the table above. Previously, the eligibility check still included some conditions in the visibility check.
• POSTabEligibilityCheckerI2Tests: similar to POSTabEligibilityCheckerTests, but all test cases are now for i2.

Steps to reproduce

i2 is back now, and the POS tab is now shown when: on a tablet, store country is eligible, remote feature flag is enabled

Store eligible for POS

• Log in to a store eligible for POS --> the POS tab should be shown after a bit
• Tap on the POS tab --> POS should be launched to the products loaded state

Store in an eligible country but not eligible for POS

• Log in to a store in an eligible country but not eligible for POS --> the POS tab should be shown after a bit
• Tap on the POS tab --> an ineligible UI should be shown

Store not in an eligible country

• Log in to a store not in an eligible country --> the POS tab should not be shown even after a while

Testing information

• @jaclync smoke tests when the i2 feature flag is disabled
• @jaclync makes sure the POS tab does not show on iPhone

Screenshots

Ineligible UI is back for a store in an eligible country but not eligible for POS:

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr15865-b6854d4
	Version	22.7
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	b6854d4
	Installation URL	0gfitedngj0h0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[joshheald]

Works as expected.

I mentioned renaming a duplicate, in my last PR, but now that you've done it the other way around I don't think it's worth undoing and redoing for a small benefit in source control history.

Thanks for the change.

[joshheald]

I don't think we're using Combine here

[jaclync]

Good catch, removed in b6854d4.

[jaclync]

Thanks for reviewing both PRs Josh, I've copied the i2 content to the main checker & tests files, with i2 files deleted now. Merging this to unblock future PRs.