-
Notifications
You must be signed in to change notification settings - Fork 121
[Woo POS] Include more information in pos_card_present_collect_payment_success event
#15892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Include more information in pos_card_present_collect_payment_success event
#15892
Conversation
Track gatewayID, countryCode, paymentMethod, cardReaderModel, and siteID to match IPP and Android implementation
pos_card_present_collect_payment_success event
Generated by 🚫 Danger |
|
|
iamgabrielma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! Just a non-blocking question regarding site_id
- Simulated device:
🔵 Tracked pos_card_present_collect_payment_success, properties: [milliseconds_since_reader_ready_to_collect_payment: 10226.0, site_id: -1, card_reader_model: CHIPPER_2X, site_url: https://indiemelon.mystagingwebsite.com, plugin_slug: woocommerce-payments, store_id: c5bd46cc-1804-4f7b-badb-bb98c449127f, was_ecommerce_trial: false, plan: , milliseconds_since_order_sync_success: 12718.0, country: US, is_wpcom_store: false, milliseconds_since_card_tapped: 8125.0, milliseconds_since_customer_interaction_started: 15913.0, payment_method_type: card, checkout_tap_count: 1, blog_id: -1]
- Physical device
🔵 Tracked pos_card_present_collect_payment_success, properties: [is_wpcom_store: false, payment_method_type: card, milliseconds_since_card_tapped: 8652.0, plugin_slug: woocommerce-payments, plan: jetpack_security_daily, site_id: 215063064, site_url: https://indiemelon.mystagingwebsite.com, checkout_tap_count: 1, milliseconds_since_reader_ready_to_collect_payment: 12794.0, milliseconds_since_customer_interaction_started: 27798.0, was_ecommerce_trial: false, blog_id: 215063064, store_id: c5bd46cc-1804-4f7b-badb-bb98c449127f, country: US, card_reader_model: STRIPE_M2, milliseconds_since_order_sync_success: 24758.0]
WooCommerce/WooCommerceTests/POS/Analytics/POSCollectOrderPaymentAnalyticsTests.swift
Outdated
Show resolved
Hide resolved
| countryCode: configuration.countryCode, | ||
| paymentMethod: capturedPaymentData.paymentMethod, | ||
| cardReaderModel: connectedReaderModel, | ||
| siteID: siteID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Do we need to track site_id explicitly? We already capture blog_id as part of the event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging, I missed this detail. I used CollectOrderPaymentAnalytics as an example, but I didn't notice we track blog_id. Indeed, it doesn't look to be necessary
…entAnalyticsTests.swift Co-authored-by: Gabriel Maldonado <[email protected]>

Track gatewayID, countryCode, paymentMethod, cardReaderModel, and siteID to match IPP and Android implementation
WOOMOB-776
Description
Track more details with POS card present, collect payment success event
Track gatewayID, countryCode, paymentMethod, cardReaderModel, and siteID to match IPP and Android implementation
Steps to reproduce
pos_card_present_collect_payment_successis tracked withgatewayID,countryCode, paymentMetho,cardReaderModel, andsiteIDTesting information
Tested on iPad Air M2 26.0
RELEASE-NOTES.txtif necessary.