Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 11, 2025

Part of WOOMOB-754

Description

This PR follows up the work in #15885 to add support for persisting Woo Shipping shipments in the local storage.

Specifically:

  • Adds new Core Data entities for shipments and shipment items fetched from Woo Shipping config
  • Adds a new relationship with shipment to the existing shipping label entity.
  • Adds a new relationship between order and shipments.
  • Adds conversion to readonly objects.

Testing steps

  • Build and run the app and confirm that the app works normally like before without any crashes upon launch.
  • Check the setup and relationships of the new entities to confirm that they all look correct.

Testing information

  • Quick regression check on simulator iPhone 16 iOS 18.4
  • Added tests for Core Data migration.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.9 milestone Jul 11, 2025
@itsmeichigo itsmeichigo added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jul 11, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 11, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 11, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15897-91f1d8b
Version22.7
Bundle IDcom.automattic.alpha.woocommerce
Commit91f1d8b
Installation URL6n8c5ksmh4r90
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review July 11, 2025 04:38
Base automatically changed from woomob-754-shipping-labels-update-shipping-label-section-in-order to trunk July 11, 2025 11:23
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left just 1 question

Comment on lines +9 to +10
@NSManaged public var siteID: Int64
@NSManaged public var orderID: Int64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to also store siteID and orderID here since those are accessible through order relationship?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order relationship is optional, so I'd prefer having non-optional IDs here instead.

@itsmeichigo itsmeichigo merged commit 0525eec into trunk Jul 15, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the woomob-754-new-entity-wooshippingshipment branch July 15, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants