-
Notifications
You must be signed in to change notification settings - Fork 121
Shipping Labels: Add new entities for WooShippingShipment and Item #15897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left just 1 question
| @NSManaged public var siteID: Int64 | ||
| @NSManaged public var orderID: Int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to also store siteID and orderID here since those are accessible through order relationship?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order relationship is optional, so I'd prefer having non-optional IDs here instead.

Part of WOOMOB-754
Description
This PR follows up the work in #15885 to add support for persisting Woo Shipping shipments in the local storage.
Specifically:
Testing steps
Testing information
Screenshots
N/A
RELEASE-NOTES.txtif necessary.