-
Notifications
You must be signed in to change notification settings - Fork 121
[Woo POS][Barcodes] Set up flow test failure screen #15903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Barcodes] Set up flow test failure screen #15903
Conversation
|
|
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like the system. Looks simple enough and fitting for a few step flows.
| } | ||
|
|
||
| // MARK: - Step Identifiers | ||
| enum PointOfSaleBarcodeScannerStepID: String, CaseIterable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized in the analytics PR as well that we need a strongly typed step definition. Therefore, it helps the analytics as well.

Part of: WOOMOB-696
Description
This PR adds the error state for test scan's failing in the Star set up flow.
To do this, I've updated the flow definition to use a dictionary, rather than a linear array. Steps now define their own transitions.
In future, we may want an associated value on the error transition to pass different errors, but it might break the hashability and be a bit of a pain. We'll see if we need it, I don't want to over-complicate at the moment.
Steps to reproduce
... > Barcode scanningRetry restarts the flow
Back takes you to the test page again.
Screenshots
error.flow.mp4
RELEASE-NOTES.txtif necessary.