Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Jul 11, 2025

Closes: WOOMOB-696
Closes: WOOMOB-806
Merge after #15904

Description

This PR splits "how to set up your products" from general barcode scanner info.

The Other flow becomes 2 steps, and the specific reader flows can show "how to set up your products" at the end.

I've also tweaked all the sizes and layouts to more closely match designs.

Steps to reproduce

  1. Launch the app, open POS
  2. Tap ... > Barcode scanning
  3. Try the Other flow – observe that it's two screens with the information split between them.
  4. Try the Star flow – observe that the final optional step is the product setup information.

Screenshots

info.screens.split.up.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 22.9 milestone Jul 11, 2025
@joshheald joshheald added type: task An internally driven task. status: feature-flagged Behind a feature flag. Milestone is not strongly held. feature: POS labels Jul 11, 2025
@joshheald joshheald requested a review from staskus July 11, 2025 13:42
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 11, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15905-a71501d
Version22.7
Bundle IDcom.automattic.alpha.woocommerce
Commita71501d
Installation URL3j7nvhl1kifa0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

buttonCustomization: PointOfSaleBarcodeScannerOptionalScannerInformationButtonCustomization(),
transitions: [
.back: .test
.optionalNext: .information,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we cannot continue using .next instead of .optionalNext here. I'll revert to .next for simplicity and re-implement in case I understand its usefulness.

Base automatically changed from woomob-696-update-gears-image to trunk July 14, 2025 11:46
@staskus staskus merged commit e68c580 into trunk Jul 14, 2025
14 checks passed
@staskus staskus deleted the issue/WOOMOB-788-separate-barcode-and-scanner-info-screens branch July 14, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants