[POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint #15906

jaclync · 2025-07-11T20:48:08Z

For WOOMOB-835
Just one review is required.

Why

This PR adds Yosemite level support for retrying plugin related checks in the POS eligibility check WOOMOB-799. The integration with the eligibility checker will be in a separate PR because this PR is already close to 500 diffs.

Description

This PR introduces POSSystemStatusService in Yosemite to efficiently load both WooCommerce plugin information and POS feature switch value from a single system status API request. This improves performance by reducing API calls when refreshing POS eligibility.

The implementation includes:

New POSSystemStatusServiceProtocol with loadWooCommercePluginAndPOSFeatureSwitch method with POSSystemStatusService implementation
Generic loadSystemStatus method in SystemStatusRemote for reusable system status requests
Test coverage for POSSystemStatusService

Steps to reproduce

The new POSSystemStatusService isn't used in the app yet. Some confidence testing on the refactored SystemStatusRemote methods would be helpful:

`SystemStatusRemote.loadSystemInformation` usage

This method is called throughout the app via SystemStatusAction.synchronizeSystemInformation. Example testing steps:

Launch the app
Go to Menu > Settings --> the WC plugin version should be shown correctly as before
Tap on Plugins --> plugins should be shown correctly as before

`SystemStatusRemote.fetchSystemStatusReport` usage

This method is called throughout the app via SystemStatusAction.fetchSystemStatusReport.

Launch the app
Go to Menu > Settings > Help & Support -> System Status Report --> the SSR should be shown correctly as before

Testing information

I tested the steps above in iPad A16 iOS 18.4 simulator.

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…response, and refactor existing remote methods to use this.

…tch value from one system status API request.

…SFeatureSwitch`.

wpmobilebot · 2025-07-11T21:03:03Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr15906-4520838`
	Version	`22.8`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`4520838`
	Installation URL	6d14okt99vbh0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma

LGTM 🚀

iamgabrielma · 2025-07-14T09:53:29Z

Modules/Sources/Networking/Remote/SystemStatusRemote.swift

+            do {
+                let mapper = SystemStatusMapper(siteID: siteID)
+                let systemStatus = try await loadSystemStatus(for: siteID,
+                                                              fields: [Field.environment, Field.activePlugins, Field.inactivePlugins],


Currently unused, but I think we're missing the settings field here?

Suggested change

fields: [Field.environment, Field.activePlugins, Field.inactivePlugins],

fields: [Field.environment, Field.activePlugins, Field.inactivePlugins, Field.settings],

SystemStatusMapper/SystemStatus currently does not need the settings field for the use case of this remote method (as in the fields in the deleted line 21), thus I don't think we need to fetch it for performance reason.

iamgabrielma · 2025-07-14T09:57:02Z

Modules/Sources/Yosemite/PointOfSale/Eligibility/POSSystemStatusService.swift

+
+        // Finds WooCommerce plugin from active plugins response.
+        guard let wcPlugin = systemStatus.activePlugins.first(where: { $0.plugin == Constants.wcPluginPath }) else {
+            return POSPluginAndFeatureInfo(wcPlugin: nil, featureValue: nil)


If no WooCommerce plugin path is found at this point of execution, should we throw here rather than returning a POSPluginAndFeatureInfo with nil values?

Good question - I thought about it before, and decided to keep this service simple and just return data if available and throw errors when the app fails to retrieve the data. The use case determines how to handle when the plugin / feature value isn't available.

Ideally, all the plugin related checks can be in Yosemite. However, right now VersionHelpers exists in the app layer and it'd require some refactoring to move it to Yosemite. If I have some time before the i2 release next Friday, I will tackle this.

iamgabrielma · 2025-07-14T09:58:22Z

Modules/Sources/Yosemite/PointOfSale/Eligibility/POSSystemStatusService.swift

+    // As `settings.enable_features` was introduced in WC version 9.9.0, this field is optional.
+    // Ref: https://github.com/woocommerce/woocommerce/pull/57168


iamgabrielma · 2025-07-14T10:01:15Z

Modules/Tests/YosemiteTests/PointOfSale/POSSystemStatusServiceTests.swift

+    @Test func loadWooCommercePluginAndPOSFeatureSwitch_returns_nil_plugin_and_nil_feature_when_woocommerce_plugin_not_found() async throws {
+        // Given
+        network.simulateResponse(requestUrlSuffix: "system_status", filename: "system-status-wc-plugin-missing")
+
+        // When
+        let result = try await sut.loadWooCommercePluginAndPOSFeatureSwitch(siteID: sampleSiteID)
+
+        // Then
+        #expect(result.wcPlugin == nil)
+        #expect(result.featureValue == nil)
+    }


Linked to the comment above regarding not finding the WooCommerce path at this point, is this a expected scenario? Or should we throw an error?

Responded in #15906 (comment).

jaclync added 3 commits July 11, 2025 10:20

SystemStatusRemote: create loadSystemStatus that returns a generic …

b124751

…response, and refactor existing remote methods to use this.

Create POSSystemStatusService to load WC plugin and POS feature swi…

b11e98a

…tch value from one system status API request.

Add test cases for `POSSystemStatusService.loadWooCommercePluginAndPO…

3a26eb2

…SFeatureSwitch`.

jaclync added the type: task An internally driven task. label Jul 11, 2025

jaclync added this to the 22.9 milestone Jul 11, 2025

jaclync changed the title ~~Add POSSystemStatusService to load WooCommerce plugin and POS feature switch from system status API~~ [POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint Jul 11, 2025

Move SystemStatusRemote.Field raw value to a private extension.

961d2f9

Remove unused error enum.

4520838

jaclync requested review from iamgabrielma and staskus July 12, 2025 01:14

iamgabrielma self-assigned this Jul 14, 2025

iamgabrielma approved these changes Jul 14, 2025

View reviewed changes

jaclync merged commit 0ea5d32 into trunk Jul 14, 2025
14 checks passed

jaclync deleted the feat/WOOMOB-835-load-wc-plugin-pos-feature-switch-from-system-status branch July 14, 2025 14:21

jaclync mentioned this pull request Jul 14, 2025

[POS as a tab i2] Refresh POS eligibility in ineligible UI: WC plugin ineligible cases #15908

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint #15906

[POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint #15906

Uh oh!

jaclync commented Jul 11, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 11, 2025 •

edited

Loading

Uh oh!

iamgabrielma left a comment

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

jaclync Jul 14, 2025 •

edited

Loading

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

jaclync Jul 14, 2025

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

jaclync Jul 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	fields: [Field.environment, Field.activePlugins, Field.inactivePlugins],
	fields: [Field.environment, Field.activePlugins, Field.inactivePlugins, Field.settings],

		// As `settings.enable_features` was introduced in WC version 9.9.0, this field is optional.
		// Ref: https://github.com/woocommerce/woocommerce/pull/57168

[POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint #15906

[POS as a tab i2] Support loading WC plugin and POS feature switch from system status endpoint #15906

Uh oh!

Conversation

jaclync commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Description

Steps to reproduce

SystemStatusRemote.loadSystemInformation usage

SystemStatusRemote.fetchSystemStatusReport usage

Testing information

Uh oh!

wpmobilebot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma left a comment

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

jaclync Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

jaclync Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

jaclync Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jaclync commented Jul 11, 2025 •

edited

Loading

`SystemStatusRemote.loadSystemInformation` usage

`SystemStatusRemote.fetchSystemStatusReport` usage

wpmobilebot commented Jul 11, 2025 •

edited

Loading

jaclync Jul 14, 2025 •

edited

Loading