-
Notifications
You must be signed in to change notification settings - Fork 121
[POS as a tab i2] Analytics & enable feature flag #15918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
iamgabrielma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✅ pos_ineligible_ui_shown - store_currency
✅ pos_ineligible_ui_retry_tapped - store_currency
✅ pos_ineligible_ui_shown - feature_switch_disabled
✅ pos_ineligible_ui_retry_tapped - feature_switch_disabled
✅ pos_items_fetched
Nit: Looks like we might be tracking pos_loaded twice when we have non-eligible screens: It tracks it once when we attempt to enter POS but we face the non-eligible view, then tracks again when it passes through the checks and we're allowed into POS. Most likely because the event is tied to the loading screen which we expected to load only once up till now.
…aleLoadingView` (which can be shown anytime within POS) to `PointOfSaleDashboardView`.
Thanks for catching this issue! I fixed this in 5163038 by moving the
To match this behavior, the event is only logged once when the POS reaches the content state where items are loaded. If the store is ineligible for POS, the event won't be logged until the eligibility is fixed. |

For WOOMOB-858
Just one review is required.
Description
This pull request adds analytics tracking the ineligible view being shown and when the retry CTA is tapped.
The implementation is based on the plan WOOMOB-856:
Steps to reproduce
Prerequisite: the store is ineligible for POS for two fixable reasons (e.g. unsupported store currency, and POS feature switch disabled in wp-admin > WC Settings > Advanced > Features).
– Launch the app connected to a store in the prerequisite -> POS tab should appear shortly
– Tap on the POS tab –>
pos_ineligible_ui_shownevent should be tracked with propertyreasonin one of the optionsstore_currency|wc_plugin_version|feature_switch_disabled|unknown_wc_plugin|ios_version|otherthat matches the ineligible reason– Fix the first reason
– In the app, tap
Retry->pos_ineligible_ui_retry_tappedevent should be tracked with the samereasonproperty. After the ineligible UI is updated with the second reason,pos_ineligible_ui_shownevent should be tracked with the correspondingreasonproperty– Fix the second reason
– In the app, tap Retry ->
pos_ineligible_ui_retry_tappedevent should be tracked with the same reason property. then it should enter POS