-
Notifications
You must be signed in to change notification settings - Fork 121
[POS as a tab i2] Streamline loading UI animation when transitioning from eligibility check to items loading #15922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jaclync
merged 6 commits into
trunk
from
feat/WOOMOB-767-streamline-indefinite-circular-animation
Jul 18, 2025
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf13f8b
PointOfSaleLoadingView: remove unused time tracking code.
jaclync 3318c19
Move POS eligibility state based UI from `PointOfSaleEntryPointView` …
jaclync 4eceb20
Fix ineligible UI not being fullscreen.
jaclync ac82fdb
Update floating control visibility to hide for ineligible case.
jaclync ea85627
Move `PointOfSaleAggregateModel` initializer in test cases to a priva…
jaclync dda7a33
Revert changes in `PointOfSaleLoadingView` as it tracks `pointOfSaleL…
jaclync File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
WooCommerce/Classes/POS/ViewHelpers/PointOfSaleDashboardViewHelper.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| @available(iOS 17.0, *) | ||
| struct PointOfSaleDashboardViewHelper { | ||
| static func determineViewState( | ||
| eligibilityState: POSEligibilityState?, | ||
| itemsContainerState: ItemsContainerState, | ||
| horizontalSizeClass: UserInterfaceSizeClass? | ||
| ) -> PointOfSaleDashboardView.ViewState { | ||
| guard case .regular = horizontalSizeClass else { | ||
| return .unsupportedWidth | ||
| } | ||
|
|
||
| guard let eligibilityState else { | ||
| return .loading | ||
| } | ||
|
|
||
| switch eligibilityState { | ||
| case .eligible: | ||
| switch itemsContainerState { | ||
| case .loading: | ||
| return .loading | ||
| case .error(let error): | ||
| return .error(error) | ||
| case .content: | ||
| return .content | ||
| } | ||
| case .ineligible(let reason): | ||
| return .ineligible(reason: reason) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @available(iOS 17.0, *) | ||
| extension PointOfSaleDashboardView.ViewState { | ||
| var showsFloatingControl: Bool { | ||
| switch self { | ||
| case .content, .error, .unsupportedWidth: | ||
| return true | ||
| case .loading, .ineligible: | ||
| return false | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner view hierarchy 💯