-
Notifications
You must be signed in to change notification settings - Fork 121
Replace full objects for products in Blaze and Shipping Label flows #15965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
…ead-can-cause' into woomob-619-simplified-product-objects
…ead-can-cause' into woomob-619-simplified-product-objects
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works as described.
…ead-can-cause' into woomob-619-simplified-product-objects
…ead-can-cause' into woomob-619-simplified-product-objects
|
I've added new changes to this PR to use generic results controllers and add separate types for Blaze and Shipping Label flows. This PR is ready for another look @RafaelKayumov 🙏 |

Part of WOOMOB-619
Description
This PR continues the work in #15959 to replace the full product objects in Blaze and Shipping Label flows to improve the performance of loading product details, since these flows don't require all details from the full product objects.
Changes include mostly just replacement of the type and addition of extra properties needed for product items in the Blaze and Shipping Label flow.
Also, to avoid trigger conversions more than necessary, the computed variables for fetched objects have been replaced.
Testing steps
TC1: Blaze dashboard card
TC2: Blaze campaign creation
TC3: Shipping Label
Testing information
Tested and confirmed with simulator iPhone 16 iOS 18.4.
Screenshots
No UI changes.
RELEASE-NOTES.txtif necessary.