Skip to content

Replace full objects for products in Blaze and Shipping Label flows #15965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 7, 2025
Merged

Replace full objects for products in Blaze and Shipping Label flows #15965

merged 20 commits into from
Aug 7, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 31, 2025 •
edited
Loading

Part of WOOMOB-619

Description

This PR continues the work in #15959 to replace the full product objects in Blaze and Shipping Label flows to improve the performance of loading product details, since these flows don't require all details from the full product objects.

Changes include mostly just replacement of the type and addition of extra properties needed for product items in the Blaze and Shipping Label flow.

Also, to avoid trigger conversions more than necessary, the computed variables for fetched objects have been replaced.

Testing steps

TC1: Blaze dashboard card

  1. Log in to a store with either Blaze extension or hosted on WPCom.
  2. Enable the Blaze card on the dashboard.
  3. If the store has no campaign, proceed to step 4. Otherwise, comment out these lines to force display the product on the dashboard card.
  4. Confirm that the latest product is displayed on the card as a suggestion.

TC2: Blaze campaign creation

  1. Log in to a WPCom store or install Blaze extension to your self-hosted store.
  2. Navigate to the Products tab and select any published product.
  3. Select Promote with Blaze.
  4. Confirm that the campaign creation form displays the correct product image and relevant tag line and description for the product.
  5. Select Ad Destination and confirm that the product URL is correct for the product.

TC3: Shipping Label

  1. Pre-requisite: Install the WooShipping extension on your test store and log in to the same store on the app as the store owner.
  2. Navigate to the Orders tab and select a paid order with at least one physical product.
  3. Confirm that the Create shipping label button is available.
  4. Select Create shipping label button.
  5. Confirm that the purchase form displays the correct products.

Testing information

Tested and confirmed with simulator iPhone 16 iOS 18.4.

Screenshots

No UI changes.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.0 milestone Jul 31, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. feature: Blaze Related to the integration of the Blaze ads platform Enhancement labels Jul 31, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 31, 2025 •
edited
Loading

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 23.0. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 31, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15965-b0623c3
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commitb0623c3
Installation URL1uupdkudhi638
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review July 31, 2025 10:10
RafaelKayumov
RafaelKayumov approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as described.

@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Aug 5, 2025

I've added new changes to this PR to use generic results controllers and add separate types for Blaze and Shipping Label flows. This PR is ready for another look @RafaelKayumov 🙏

Base automatically changed from woomob-619-xcode-warnings-performing-io-on-the-main-thread-can-cause to trunk August 7, 2025 01:18
@itsmeichigo itsmeichigo enabled auto-merge August 7, 2025 01:19
@itsmeichigo itsmeichigo disabled auto-merge August 7, 2025 03:32
@itsmeichigo itsmeichigo enabled auto-merge August 7, 2025 04:00
@itsmeichigo itsmeichigo merged commit 04022ac into trunk Aug 7, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the woomob-619-simplified-product-objects branch August 7, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

Enhancement feature: Blaze Related to the integration of the Blaze ads platform feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @RafaelKayumov