-
Notifications
You must be signed in to change notification settings - Fork 121
Product List: Replace full product objects with simplified objects #15966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
89348f1
Add missing properties
itsmeichigo 25ccab4
Make some entities conform to ListItemConvertible with default implem…
itsmeichigo 5825c4c
Replace full product objects in product list
itsmeichigo 07f9d23
Fix swiftlint issue
itsmeichigo df8c1a5
Merge branch 'woomob-619-xcode-warnings-performing-io-on-the-main-thr…
itsmeichigo 177a232
Move conversion from full object to separate file
itsmeichigo 2e10b2f
Update tests
itsmeichigo 8fefa69
Merge branch 'woomob-619-xcode-warnings-performing-io-on-the-main-thr…
itsmeichigo 58de948
Unify logic for createStockText
itsmeichigo 7962628
Revert changes made to PaginatedListSelectorViewController
itsmeichigo 1385645
Revert changes made to SearchUICommand and related files
itsmeichigo 3cdd596
Revert redundant changes
itsmeichigo c508d42
Remove redundant conformance
itsmeichigo ca151c9
Update release notes
itsmeichigo 2eeae10
Merge branch 'woomob-619-xcode-warnings-performing-io-on-the-main-thr…
itsmeichigo cc94596
Add ProductListItem on the view layer
itsmeichigo 6051068
Merge branch 'woomob-619-xcode-warnings-performing-io-on-the-main-thr…
itsmeichigo c612ea0
Remove added tests for ResultsController
itsmeichigo 1c90859
Merge branch 'woomob-619-xcode-warnings-performing-io-on-the-main-thr…
itsmeichigo ce5913b
Add workaround for using simplified objects for display in list items
itsmeichigo 42ff794
Fix swiftlint
itsmeichigo 3c03c14
Merge branch 'trunk' into woomob-619-product-list-update
itsmeichigo 30e5dec
Remove unused properties
itsmeichigo 47c60a6
Merge branch 'trunk' into woomob-619-product-list-update
itsmeichigo 54706cd
Ignore periphery for OrderDetailsProduct initializer
itsmeichigo 21bb2e8
Restore initializer for ProductDetailsCellViewModel
itsmeichigo 39a54d1
Remove unused property
itsmeichigo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍