Skip to content

Fix iPhone UI test failure in trunk from customer details address form #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2025
Merged

Fix iPhone UI test failure in trunk from customer details address form #15969

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76ce343
Fix iPhone UI test failure from the new address picker CTA pushing do…
jaclync Aug 1, 2025
98da5ba
Temporarily enable UI tests in branch.
jaclync Aug 1, 2025
221103b
Revert "Temporarily enable UI tests in branch."
jaclync Aug 1, 2025
b432a68
Add a comment on adding `\n` to dismiss keyboard.
jaclync Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Modules/Sources/UITestsFoundation/Screens/Orders/CustomerDetailsScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,12 @@ public final class CustomerDetailsScreen: ScreenObject {
@discardableResult
public func enterCustomerDetails(name: String) throws -> UnifiedOrderScreen {
billingFirstNameField.tap()
billingFirstNameField.typeText(name)
// `\n` was added after the first name input in order to dismiss the keyboard so that the address toggle is interactive in shorter screens.
billingFirstNameField.typeText("\(name)\n")
Comment on lines +43 to +44
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using \n to dismiss the keyboard is a workaround that may not be reliable across different iOS versions or keyboard configurations. Consider using a more explicit keyboard dismissal method such as tapping a done button or using app.keyboards.buttons["Done"].tap() if available.

Suggested change
// `\n` was added after the first name input in order to dismiss the keyboard so that the address toggle is interactive in shorter screens.
billingFirstNameField.typeText("\(name)\n")
// Tap the done button to dismiss the keyboard after entering the first name.
billingFirstNameField.typeText(name)
doneButton.tap()

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@jaclync jaclync Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Done" can be unreliable as well, as the OS can change the keyboard return button in future iOS versions.

let tableView = app.tables.firstMatch
tableView.swipeUp()
addressToggleSet(to: "1")
tableView.swipeUp()
Comment on lines 47 to +48

This comment was marked as off-topic.

Sign in to view

shippingFirstNameField.tap()
shippingFirstNameField.typeText(name)
doneButton.tap()
Expand Down