Jetpack Setup: Update Yosemite layer with new connection endpoints #15977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeichigo
added
type: task
Collaborator
|
|
RafaelKayumov
approved these changes
Aug 6, 2025
| provisionResponse: JetpackConnectionProvisionResponse, | ||
| network: Network, | ||
| completion: @escaping (Result<Void, Error>) -> Void) { | ||
| let remote = SiteRemote(network: network, dotcomClientID: "", dotcomClientSecret: "") |
Contributor
There was a problem hiding this comment.
Will this be populated by ApiCredentials values in a following PR?
Contributor
Author
There was a problem hiding this comment.
The IDs are not necessary for using the createSite method. I added a comment in 3c37259 to clarify this.
| /// The result to return in `updateSiteTitle` | ||
| private var updateSiteTitleResult: Result<Void, Error>? | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Super nit: an empty line here and there
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-965
Description
This PR updates the Yosemite layer with the new Jetpack connection endpoints added in #15976.
Testing steps
Just CI passing should be sufficient, the new actions haven't been used yet.
RELEASE-NOTES.txtif necessary.