Skip to content

Delete unused code post Periphery integration #15986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Delete unused code post Periphery integration #15986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4acd1ab
Delete unused `showingMapPicker`
RafaelKayumov Aug 6, 2025
220cbb8
Silence Periphery for retained observer
RafaelKayumov Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions WooCommerce/Classes/POS/Presentation/Barcode Scanning/BarcodeScannerContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ struct BarcodeScannerContainerRepresentable: UIViewControllerRepresentable {
/// based on VoiceOver state. Uses GameController framework for optimal performance when possible,
/// and falls back to UIKit UIPress events when VoiceOver is enabled.
final class GameControllerBarcodeScannerHostingController: UIHostingController<EmptyView> {
/// periphery: ignore - retain `gameControllerObserver` to keep it alive
private(set) var gameControllerObserver: GameControllerBarcodeObserver?

private(set) var uiKitObserver: UIKitBarcodeObserver?

private let configuration: HIDBarcodeParserConfiguration
Expand Down
2 changes: 0 additions & 2 deletions WooCommerce/Classes/ViewRelated/Orders/Order Details/Address Edit/EditOrderAddressForm.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ struct EditOrderAddressForm<ViewModel: AddressFormViewModelProtocol>: View {
@Environment(\.safeAreaInsets) var safeAreaInsets: EdgeInsets
@State private var showingCustomerSearch: Bool = false

@State private var showingMapPicker = false

var body: some View {
Group {
ScrollView {
Expand Down