Skip to content

iPad: Fix split view not working after the initial launch #2 #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

iPad: Fix split view not working after the initial launch #2 #15989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WooCommerce/Classes/ViewRelated/MainTabBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,14 @@ final class MainTabBarController: UITabBarController {

delegate = self

fixTabBarTraitCollectionOnIpadForiOS18()

// POS tab is hidden by default.
updateTabViewControllers(isPOSTabVisible: false)
observeSiteIDForViewControllers()
observeProductImageUploadStatusUpdates()

startListeningToHubMenuTabBadgeUpdates()

fixTabBarTraitCollectionOnIpadForiOS18()
}

override func viewWillAppear(_ animated: Bool) {
Expand Down Expand Up @@ -294,7 +294,7 @@ final class MainTabBarController: UITabBarController {
private func fixTabBarTraitCollectionOnIpadForiOS18() {
if #available(iOS 18.0, *), UIDevice.current.userInterfaceIdiom == .pad {
traitOverrides.horizontalSizeClass = .compact
if let rootHorizontalSizeClass = view.window?.traitCollection.horizontalSizeClass {
if let rootHorizontalSizeClass = AppDelegate.shared.window?.traitCollection.horizontalSizeClass {
tabBar.traitOverrides.horizontalSizeClass = rootHorizontalSizeClass
if let viewControllers {
for vc in viewControllers {
Expand Down
Loading