Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Aug 8, 2025

Description

This PR fixes a visual issue in the TaxEducationalDialogView where the modal's corners were displayed incorrectly due to the ScrollView being the outermost container. This caused the background and corner radius to misbehave—specifically, the bottom corners appeared square until the content was scrolled.

The solution involves moving the styled container (VStack with background and corner radius) outside the ScrollView, ensuring the modal frame is preserved regardless of scroll interaction. The GeometryReader is not necessary, and this removed.

Steps to reproduce

With an increased device font size and a tax rate set in the settings of your store

  1. Go to Orders
  2. Tap on + to create a new order
  3. Add a product
  4. Tap on Set New Tax Rate
  5. Tap on the ? button
  6. The content should be scrollable. Before, the bottom corners appear square initially and become rounded only after scrolling. Now it is rounded.

Testing information

Tested on iPad with Largest accessibility siw

Screenshots

ScreenRecording_08-07-2025.17-11-08_1.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@toupper toupper added this to the 23.1 milestone Aug 8, 2025
@toupper toupper requested a review from joshheald August 8, 2025 09:26
@toupper toupper added type: task An internally driven task. feature: order creation All tasks related to creating an order labels Aug 8, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15997-ab1ea36
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commitab1ea36
Installation URL18s709rjsge9o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald self-assigned this Aug 8, 2025
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks for improving this

@toupper toupper merged commit 805a719 into trunk Aug 8, 2025
20 of 22 checks passed
@toupper toupper deleted the issue/WOOMOB-135-fix-scroll-view-tax-modal branch August 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order creation All tasks related to creating an order type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants