Skip to content

[WCiOS17] Address some CardReader warnings #15998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2025
Merged

[WCiOS17] Address some CardReader warnings #15998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6708739
explicitely handle non-supported cases for PaymentMethodDetails
iamgabrielma Aug 8, 2025
83a04d2
update default learnMoreURL to use IPP URL
iamgabrielma Aug 8, 2025
e5f1ab1
assign unused URL result to learnMoreURL
iamgabrielma Aug 8, 2025
0077d11
update release notes
iamgabrielma Aug 8, 2025
7516d5d
Merge branch 'trunk' into task/ios17-cardreader-warnings
iamgabrielma Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Sources/Hardware/CardReader/StripeCardReader/PaymentMethod+Stripe.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ extension PaymentMethod {
return
}
self = .interacPresent(details: CardPresentTransactionDetails(details: details))
case .unknown:
case .affirm, .wechatPay, .unknown:
self = .unknown
@unknown default:
self = .unknown
Expand Down
2 changes: 1 addition & 1 deletion RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

23.1
-----

- [*] Payments: Updated the In-Person Payments `Learn More` redirection to display the correct page based on the selected payment provider [https://github.com/woocommerce/woocommerce-ios/pull/15998]

23.0
-----
Expand Down
4 changes: 2 additions & 2 deletions ...s/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
self.knownReaderProvider = knownReaderProvider
self.configuration = configuration
self.cardReaderConnectionAnalyticsTracker = cardReaderConnectionAnalyticsTracker
self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.setUpTapToPayLearnMoreURL
self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.manageCardReaderLearnMoreURL

beginKnownReaderObservation()
beginConnectedReaderObservation()
Expand Down Expand Up @@ -109,7 +109,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
private func updateLearnMoreUrl(stores: StoresManager) {
let loadLearnMoreUrlAction = CardPresentPaymentAction
.loadActivePaymentGatewayExtension() { [weak self] result in
result.manageCardReaderLearnMoreURL
self?.learnMoreURL = result.manageCardReaderLearnMoreURL
}
stores.dispatch(loadLearnMoreUrlAction)
}
Expand Down