-
Notifications
You must be signed in to change notification settings - Fork 121
Jetpack Setup: Improve web connection flow for outdated plugin #16001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @itsmeichigo, the scenario works well for both:
- Connecting an existing store from the site picker.
- For Application Passwords where the user used a WebView for authorization.
But the flow fails for Application Passwords where native login was used, check my comment below.
Also, a very minor nit, we show validating for the connection step before the user handles the connection, normally it should be shown only after the connection was established, and we are validating it, notice the difference between Android and iOS:
| Android | iOS |
|---|---|
Screen_recording_20250813_161423.mp4 |
Simulator.Screen.Recording.-.iPhone.16.-.2025-08-13.at.15.58.03.mp4 |
As said above, this is very minor, so I wouldn't spend a lot of time on it.
| let usingApplicationPassword: Bool = { | ||
| if case .some(.applicationPassword) = stores.sessionManager.defaultCredentials { | ||
| return true | ||
| } | ||
| return false | ||
| }() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition doesn't work as expected when the user is signed in using site credentials natively, as we'll get .wporg credentials in this case:
The same issue also occurs in tracking here and I missed during the review of the previous PR (sorry).
|
Thank you Hicham for spotting the issues! I addressed them in subsequent commits, this PR is ready for another look 🙏 |
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @itsmeichigo, ![]()

Part of WOOMOB-965
Description
This PR updates the web connection flow:
{site_url}/wp-admin/admin.php?page=jetpackto avoid forcing users to update their plugin.Testing steps
Follow TC7 in pe5sF9-42S-p2 to confirm that Jetpack connection through the web flow works for outdated plugin.
Testing information
From my testing, I could not make the
jetpack/v4/connection/datato not returnisRegistered- so I use an up-to-date Jetpack plugin on my JN site and use Proxyman to update the response to not returnisRegistered.Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-08-11.at.15.52.04.mp4
RELEASE-NOTES.txtif necessary.