-
Notifications
You must be signed in to change notification settings - Fork 121
[POS Settings] Feature flag and present settings view #16009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POS Settings] Feature flag and present settings view #16009
Conversation
|
|
jaclync
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 🚀 just a comment about deprecated NavigationView.
| struct PointOfSaleSettingsView: View { | ||
| @Environment(\.dismiss) private var dismiss | ||
| var body: some View { | ||
| NavigationView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As NavigationView is deprecated, can we replace it with NavigationStack or NavigationSplitView?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I used the NavigationView just temporarily. I'm experimenting now with both Stack or SplitView to see what would make more sense here, as well as with a custom view like we do Itemlist/Cart depending how much flexibility the new APIs offer 👍
| Text("Settings") | ||
| .toolbar { | ||
| ToolbarItem(placement: .navigationBarTrailing) { | ||
| Button("Done") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these strings are just for the dummy view and will be replaced or localized later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right!

Closes WOOMOB-1021
Description
This PR adds a feature flag for POS Settings i1, as well as a new button to the CTA entry point that will present a full screen settings dummy view.
Testing information
pointOfSaleSettingsi1totrueSettingsbuttonScreenshots
Screen.Recording.2025-08-14.at.11.21.03.mov
RELEASE-NOTES.txtif necessary.