Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Aug 14, 2025

Closes WOOMOB-1021

Description

This PR adds a feature flag for POS Settings i1, as well as a new button to the CTA entry point that will present a full screen settings dummy view.

Testing information

  • Set pointOfSaleSettingsi1 to true
  • Navigate to POS, and tap the Settings button
  • Observe the dummy view presented as full screen cover. Close it.

Screenshots

Screen.Recording.2025-08-14.at.11.21.03.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Aug 14, 2025
@iamgabrielma iamgabrielma added this to the 23.1 milestone Aug 14, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review August 14, 2025 04:31
Base automatically changed from task/create-pos-full-screen-cover to trunk August 14, 2025 04:33
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16009-fe941c1
Version23.0
Bundle IDcom.automattic.alpha.woocommerce
Commitfe941c1
Installation URL3dfacdtlpmdrg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma requested a review from jaclync August 14, 2025 04:57
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🚀 just a comment about deprecated NavigationView.

struct PointOfSaleSettingsView: View {
@Environment(\.dismiss) private var dismiss
var body: some View {
NavigationView {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I used the NavigationView just temporarily. I'm experimenting now with both Stack or SplitView to see what would make more sense here, as well as with a custom view like we do Itemlist/Cart depending how much flexibility the new APIs offer 👍

Comment on lines +7 to +10
Text("Settings")
.toolbar {
ToolbarItem(placement: .navigationBarTrailing) {
Button("Done") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these strings are just for the dummy view and will be replaced or localized later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

@iamgabrielma iamgabrielma merged commit 047ccd8 into trunk Aug 15, 2025
27 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-1021-feature-flag-and-settings-view-presentation branch August 15, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants