-
Notifications
You must be signed in to change notification settings - Fork 121
Order details: Display all items in a shipment when there are no created shipments #16010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order details: Display all items in a shipment when there are no created shipments #16010
Conversation
|
|
…-case-when-no-shipments-are
| var shouldShowShippingLabelCreation: Bool { | ||
| if featureFlags.isFeatureFlagEnabled(.revampedShippingLabelCreation) { | ||
| return isEligibleForShippingLabelCreation && !isEligibleForPayment && shipments.isEmpty | ||
| } | ||
| return isEligibleForShippingLabelCreation && shippingLabels.nonRefunded.isEmpty && !isEligibleForPayment | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmeichigo should we hide the button also for users using the old plugin? I assumed the new UI and all the changes should be applied only to the new plugin. This change breaks the functionality completely for old plugin users, there is now way to start shipping label creation, as we try to open the new form but it fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this issue! I prefer to unify the UI to make the code easier to maintain, so I removed the workaround for woo shipping check in 4b251a6. This was added when I introduced the new UI and is no longer needed with the changes in this PR.
This PR is ready for another look 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmeichigo I think there is still an issue, we show the new UI even when the order has existing shipping labels, and then there is now way to print the labels nor see their details, this happens a short loading where the labels are correctly shown as you can see from the following video:
Simulator.Screen.Recording.-.iPhone.16.-.2025-08-18.at.10.10.48.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For information, this site had Woo Shipping installed before, and I disabled it, in case this is necessary to reproduce the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing that issue. I added a fix in 640a385, it should avoid creating shipments for the legacy plugin. I tested with multiple packages and that works as well.
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks @itsmeichigo for addressing the issue I reported.

Closes WOOMOB-1011
Description
This PR updates the order details screen to always displays the shipping labels section if the order is eligible for label creation.
The old button and info for creating labels in the Products section have also been removed.
Testing steps
Testing information
Tested and verified on simulator iPhone 16 iOS 18.2.
Screenshots
RELEASE-NOTES.txtif necessary.