Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Aug 14, 2025

Closes WOOMOB-1011

Description

This PR updates the order details screen to always displays the shipping labels section if the order is eligible for label creation.

The old button and info for creating labels in the Products section have also been removed.

Testing steps

  1. Log in to a test store with Woo Shipping setup.
  2. Navigate to Orders tab and create an order with physical items.
  3. Update the order status to processing or collect payment for the order.
  4. Open the order details and confirm that the Create shipping label button is displayed in the Shipping labels section.
  5. Optional: purchase a label for the order with all the items (without splitting shipments). Confirm that the order details screen then displays the purchased label in the Shipping Label section.
  6. Open another order with only virtual products and confirm that the shipping label section is not displayed.

Testing information

Tested and verified on simulator iPhone 16 iOS 18.2.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.1 milestone Aug 14, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Enhancement labels Aug 14, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 14, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16010-640a385
Version23.0
Bundle IDcom.automattic.alpha.woocommerce
Commit640a385
Installation URL0a4ee98fuq5ig
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review August 15, 2025 06:27
Comment on lines -66 to -71
var shouldShowShippingLabelCreation: Bool {
if featureFlags.isFeatureFlagEnabled(.revampedShippingLabelCreation) {
return isEligibleForShippingLabelCreation && !isEligibleForPayment && shipments.isEmpty
}
return isEligibleForShippingLabelCreation && shippingLabels.nonRefunded.isEmpty && !isEligibleForPayment
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmeichigo should we hide the button also for users using the old plugin? I assumed the new UI and all the changes should be applied only to the new plugin. This change breaks the functionality completely for old plugin users, there is now way to start shipping label creation, as we try to open the new form but it fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this issue! I prefer to unify the UI to make the code easier to maintain, so I removed the workaround for woo shipping check in 4b251a6. This was added when I introduced the new UI and is no longer needed with the changes in this PR.

This PR is ready for another look 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmeichigo I think there is still an issue, we show the new UI even when the order has existing shipping labels, and then there is now way to print the labels nor see their details, this happens a short loading where the labels are correctly shown as you can see from the following video:

Simulator.Screen.Recording.-.iPhone.16.-.2025-08-18.at.10.10.48.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information, this site had Woo Shipping installed before, and I disabled it, in case this is necessary to reproduce the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that issue. I added a fix in 640a385, it should avoid creating shipments for the legacy plugin. I tested with multiple packages and that works as well.

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks @itsmeichigo for addressing the issue I reported.

@itsmeichigo itsmeichigo merged commit 3f10674 into trunk Aug 19, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1011-update-order-details-screen-for-case-when-no-shipments-are branch August 19, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants