Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Aug 26, 2025

Closes WOOMOB-1036

Description

This PR adds the basic scaffolding and navigation for the Help section of POS settings, by allowing the merchant to navigate through help options and documentation in a detail view to the right, documentation and support are currently presented full screen (for now) on top of the view.

Final UI is not handled yet, this will be done separately.

https://indiemelon.mystagingwebsite.com/screen-recording-2025-08-26-at-11-17-01/

Testing information

  • In POS, tap on the ... CTA, and go to Settings
  • Tap Help
    • Where are my products will show the modal, and can redirect the merchant to order management if they wish to
    • Documentation will open a web view with the docs, full-screen
    • Get support opens the support form, once filled it's dismissed automatically and we're back to settings.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Aug 26, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 26, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added this to the 23.2 milestone Aug 26, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review August 26, 2025 04:26
@iamgabrielma iamgabrielma requested a review from staskus August 26, 2025 04:27
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 26, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16039-e2c260b
Version23.1
Bundle IDcom.automattic.alpha.woocommerce
Commite2c260b
Installation URL6tqoo2rf5r000
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

SafariView(url: WooConstants.URLs.pointOfSaleDocumentation.asURL())

}
.posFullScreenCover(isPresented: $showSupport) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I haven't done and needs to be done, is scanning needs to be disabled when settings are opened. Maybe we could create a linear task for it or just do it now. Otherwise, filling out the support form in a simulator again triggers the scanning error sound.

In ItemListView try adding @EnvironmentObject var coverManager: POSFullScreenCoverManager and in isBarcodeScanningEnabled , add && !coverManager.isPresented. Hopefully, that should be enough!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I tried it out and worked nicely. Updated: e2c260b

Base automatically changed from task/WOOMOB-1025-two-panel-settings-view to trunk August 27, 2025 00:38
Filling out the support form in the simulator will trigger the “not found” error sound from barcode scanning unless we disable it
@iamgabrielma iamgabrielma enabled auto-merge August 27, 2025 00:55
@iamgabrielma iamgabrielma merged commit 662c32a into trunk Aug 27, 2025
14 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-1036-pos-settings-help-section branch August 27, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants