-
Notifications
You must be signed in to change notification settings - Fork 121
[POS Settings] Analytics #16051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POS Settings] Analytics #16051
Conversation
Generated by 🚫 Danger |
|
|
joshheald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described...
I noticed that the "store details tapped" event doesn't fire when you open settings... which makes sense since it hasn't been tapped... but also stops us being able to compare what's shown.
WDYT about switching to say what's shown instead of what's tapped? Not a big deal either way though.
Right, we're making the assumption that Store is always shown first when the open settings action happens, and if merchants just stay in that item, it won't be tracked for comparison 🤔 Lemme raise this one with Android as well and see what they think. |
|
Thanks for the feedback Josh! I'll go ahead and merge this one now, I have no strong opinion on it, and Android prefers to keep them as they are and use |

Description
This PR adds the following track events to POS settings:
Testing
Scan Barcode, see event logged...> Settings, observe:Event registration will be done separately