POS cash payment: prefill order amount and update analytics tracking #16058

jaclync · 2025-08-29T07:42:50Z

Just one review is required.

@jaclync registers Tracks event after approval

Description

This PR enhanced the POS cash payment UX to match Android with updated analytics tracking. The cash payment input field is now pre-filled with the order total with keyboard focused for easy replacement when merchants start typing. The payment button state is properly managed based on the entered amount and loading state.

The changes remove the validation error message since the button state now provides clear visual feedback about payment readiness. Added test coverage for the currency parsing functionality to ensure robust handling of various input formats.

Steps to reproduce

Notes:

When exiting the cash payment then entering again, the previous input is shown. This is a pre-existing behavior.
The mentioned Android behavior "selects" the input text field where the selected text has a background color, but I don't think our text field currently supports this selected state (I couldn't manually select the text to see a different background color either). Please let me know if you think this is an important visual cue, I will look into the selected state support for the shared FormattableAmountTextField component separately.

Open the POS and add items to the cart
Navigate to checkout and tap on "Cash payment" button --> checkout_cash_payment_tapped should be tracked
Verify the total amount is pre-filled and the keyboard is focused
Start typing and verify the pre-filled amount is replaced. Also verify the button is disabled unless the amount is equal or higher than total
Turn on airplane mode and tap on "Mark as complete" - verify cash_payment_tapped and cash_payment_failed are tracked
Turn off airplane mode and tap on "Mark as complete" - verify cash_payment_tapped and cash_collect_payment_success are tracked

Testing information

I tested on iPad Pro 11in 3rd generation, iOS 18.5.

Screenshots

ScreenRecording_08-29-2025.16-07-20_1.MP4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…the merchant taps on cash payment from the checkout screen. Move the existing `cash_payment_tapped` event to be tracked when marking cash payment as completed.

…te button enabled state based on input & loading state, and remove validation error.

dangermattic · 2025-08-29T07:43:20Z

	1 Warning
⚠️	This PR is assigned to the milestone 23.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

wpmobilebot · 2025-08-29T07:52:04Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16058-15e4a27`
	Version	`23.1`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`15e4a27`
	Installation URL	1ke869f0hkh60

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma

LGTM! Works well, thanks for adding the additional test cases! 🚢

iamgabrielma · 2025-09-01T05:52:10Z

WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

Since we're updating this file and testing the cash payment, we could also update the warnings for iOS17 in lines 65 and 108 regarding onChange deprecation 👍

Good catch, fixed in 0dff142. Hopefully we can reset build warnings to 0 and new warnings are detected in CI in the near future.

Btw @iamgabrielma while checking your PR #16002 from the latest merge conflicts, the release notes entry seemed to get into 23.1 instead of 23.2. Not sure what impact it has though, maybe just for Peacock beta testing.

Oh, appreciated, I did move them here then it seems messed it up when merging trunk into the branch. Thanks, I'll address it 🙇

iamgabrielma · 2025-09-01T05:55:53Z

WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

-        guard validateAmountOnSubmit() else {
-            return
-        }
+        ServiceLocator.analytics.track(.pointOfSaleCashPaymentTapped)


Not necessarily for this PR, but I wonder if we should expose the analytics prop in PointOfSaleAggregateModel, so the POS Views that depend on it can use this dependency for analytics, rather than relying on calling the shared instance of service locator. Thoughts?

When reviewing Povilas' POS modularization PRs in the last HACK Week, he updated all the ServiceLocator analytics usage with an Analytics environment variable from the top level view for all POS views to access. I hope his work gets merged in soon.

I think I'll bring some of these things to the trunk, without the POS module itself, so it could be used within the code now.

iamgabrielma · 2025-09-01T06:05:18Z

WooCommerce/Classes/POS/ViewHelpers/CollectCashViewHelper.swift

            return false
        }
-        return true
+        return inputDecimal >= orderDecimal && !isLoading


nit: I don't find this function specially readable, perhaps just by switching the order a bit and extracting logic from the guard makes it clearer? Could be entirely personal so feel free to ignore (untested!):

func isPaymentButtonEnabled(orderTotal: String, textFieldAmountInput: String, isLoading: Bool) -> Bool { if isLoading { return false } let sanitizedInput = textFieldAmountInput.isNotEmpty ? textFieldAmountInput : "0" guard let orderDecimal = parseCurrency(orderTotal), let inputDecimal = parseCurrency(sanitizedInput) else { return false } return inputDecimal >= orderDecimal }

Thanks for suggesting for better readability, updated in 7c576c0.

# Conflicts: # WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

jaclync · 2025-09-04T03:12:14Z

Thanks for the review! I responded to the comments and registered/updated the affected Tracks events. Merging shortly.

jaclync added 2 commits August 29, 2025 15:08

Add a new checkout_cash_payment_tapped POS event and track it when …

363e0b0

…the merchant taps on cash payment from the checkout screen. Move the existing `cash_payment_tapped` event to be tracked when marking cash payment as completed.

PointOfSaleCollectCashView: prefill text field with order total, upda…

7119219

…te button enabled state based on input & loading state, and remove validation error.

jaclync changed the title ~~Improve cash payment UX and add analytics tracking~~ POS: improve cash payment UX and update analytics tracking Aug 29, 2025

jaclync changed the title ~~POS: improve cash payment UX and update analytics tracking~~ POS cash payment: prefill order amount and update analytics tracking Aug 29, 2025

jaclync added the type: enhancement A request for an enhancement. label Aug 29, 2025

jaclync added this to the 23.2 milestone Aug 29, 2025

Update release notes.

004b624

jaclync added the category: tracks Related to analytics, including Tracks Events. label Aug 29, 2025

jaclync requested review from iamgabrielma and staskus August 29, 2025 23:15

iamgabrielma self-assigned this Sep 1, 2025

iamgabrielma approved these changes Sep 1, 2025

View reviewed changes

jaclync added 4 commits September 4, 2025 10:23

Merge branch 'trunk' into backlog/WOOMOB-1017-cash-payment-changes

f149da7

Fix build warnings outside of PR scope but in the same file.

0dff142

Improve readability of isPaymentButtonEnabled function.

7c576c0

Merge branch 'trunk' into backlog/WOOMOB-1017-cash-payment-changes

15e4a27

# Conflicts: # WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

jaclync enabled auto-merge September 4, 2025 03:12

jaclync merged commit 72c3a98 into trunk Sep 4, 2025
14 checks passed

jaclync deleted the backlog/WOOMOB-1017-cash-payment-changes branch September 4, 2025 03:29

POS cash payment: prefill order amount and update analytics tracking #16058

POS cash payment: prefill order amount and update analytics tracking #16058

Uh oh!

Conversation

jaclync commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

Screenshots

Uh oh!

dangermattic commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaclync commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jaclync commented Aug 29, 2025 •

edited

Loading

dangermattic commented Aug 29, 2025 •

edited

Loading

wpmobilebot commented Aug 29, 2025 •

edited

Loading