[POS Settings] Design updates #16065
Conversation
|
|
| } | ||
| .listRowSeparator(.hidden) | ||
| } | ||
| .listStyle(.plain) |
There was a problem hiding this comment.
In general I found very tricky to adapt Lists to the POS style, most likely when we implement the next iteration of designs we want to get rid of List entirely and build the view up from zero.
There was a problem hiding this comment.
For item list or coupons we use InfiniteScrollView + LazyVStack + ForEach. Maybe this is is where we will want to go with settings, not sure.
staskus
left a comment
staskus
left a comment
There was a problem hiding this comment.
✅ In general, looks nice! And fairly close to the i1 of designs that was recently shared. I shared two observations on the UI from my side.
Loading State - Store Information
Loading is shown within a card design while there's no cart design after loading. We could just show a shimmering line on a text while loading is happening.
Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-09-01.at.10.15.35.mov
Header Alignment
Visually, both navigation views not aligning don't look good, it should stay in the same position as the title for consistency.
| } | ||
| .listRowSeparator(.hidden) | ||
| } | ||
| .listStyle(.plain) |
There was a problem hiding this comment.
For item list or coupons we use InfiniteScrollView + LazyVStack + ForEach. Maybe this is is where we will want to go with settings, not sure.
|
Thanks for the review @staskus !
True that, updated here: df81a6f
Ah, good catch. I updated it here to use the POSHeader aswell, rather than the toolbar API here 87a46da which made the view less messier regarding modifiers: Untitled-20250901.mov
Thanks! I'll experiment with that this week, see if we want to update it now or later 👍 |
iamgabrielma
deleted the
task/WOOMOB-1162-pos-settings-design-updates-1
branch
|
@iamgabrielma, thank you for the updates, looks good! |
Closes WOOMOB-1162
Description
This PR updates the UI for POS Settings following the wireframes on pdfdoF-7RJ-p2 and existing POS styles for overall consistency. Note that we do not have final designs yet, what's in this PR will most likely be final for releasing i1. Initial designs have just been published at pdfdoF-80C-p2 so I took loose inspiration for the details while are being discussed and polished.
Android's UI can be seen in the project update for further reference if needed.
Split view and large font sizes are not handled in this PR, will be done separately.
Testing
All changes are UI-only. In POS, navigate to
...>Settingsand explore them in both light and dark mode.