Skip to content

[POS Settings] Store section design updates #16070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2025
Merged

[POS Settings] Store section design updates #16070

merged 5 commits into from
Sep 3, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Sep 2, 2025 •
edited
Loading

Closes WOOMOB-1228

Description

This PR addresses feedback from the CFT by:

  • Adding a Store title to the top of the Store section
  • Switching from List for Scrollview
  • Refactoring into smaller subviews
  • Updated the selection color on dark mode to be more prominent

Testing information

  • Go to POS > Settings > Store section. Observe that all fields load appropiately in normal and larger accessibility sizes.
Default Larger size
Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-09-02 at 09 12 43 Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-09-02 at 09 12 51
Selection dark before selection dark after
Screenshot 2025-09-02 at 11 55 25 Screenshot 2025-09-02 at 11 53 36

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Sep 2, 2025
@iamgabrielma iamgabrielma added this to the 23.2 milestone Sep 2, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 2, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16070-7679fd1
Version23.1
Bundle IDcom.automattic.alpha.woocommerce
Commit7679fd1
Installation URL72nftlni073vg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Sep 2, 2025

Only 1 review is needed!

@iamgabrielma iamgabrielma marked this pull request as ready for review September 2, 2025 02:15
@iamgabrielma iamgabrielma mentioned this pull request Sep 2, 2025
Merged
staskus
staskus approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

@iamgabrielma iamgabrielma mentioned this pull request Sep 3, 2025
Merged
Base automatically changed from task/WOOMOB-1221-pos-settings-a11y-improvements to trunk September 3, 2025 02:09
@iamgabrielma iamgabrielma merged commit 4470c01 into trunk Sep 3, 2025
16 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-1228-store-section-design-updates branch September 3, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

No one assigned

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Milestone

23.2

Development

Successfully merging this pull request may close these issues.

4 participants

@iamgabrielma @wpmobilebot @staskus