Skip to content

Shipping Labels: Fix issue mapping shipments after updating for REST API response #16078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

Shipping Labels: Fix issue mapping shipments after updating for REST API response #16078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/Sources/Networking/Mapper/WooShippingUpdateShipmentMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ struct WooShippingUpdateShipmentMapper: Mapper {
///
func map(response: Data) throws -> WooShippingShipments {
let decoder = JSONDecoder()
if hasDataEnvelope(in: response) {
do {
return try decoder.decode(WooShippingUpdateShipmentResponseEnvelope.self, from: response).data.shipments
} else {
} catch {
return try decoder.decode(WooShippingUpdateShipmentResponse.self, from: response).shipments
}
}
Expand Down
2 changes: 1 addition & 1 deletion Modules/Tests/NetworkingTests/Mapper/WooShippingUpdateShipmentMapperTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class WooShippingUpdateShipmentMapperTests: XCTestCase {
}

func test_shipments_are_properly_parsed_when_response_has_no_data_envelope() throws {
guard let shipments = mapLoadShippingLabelConfig() else {
guard let shipments = mapLoadShippingLabelConfigWithoutDataEnvelope() else {
XCTFail()
return
}
Expand Down