Skip to content

[CIAB] Distinguish between Garden/CIAB and regular sites #16095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2025
Merged

[CIAB] Distinguish between Garden/CIAB and regular sites #16095

merged 2 commits into from
Sep 10, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 5, 2025 •
edited
Loading

WOOMOB-1268

Description

  • Adds CIABEligibilityChecker responsible for checking a site if it's a CIAB site.
  • Defines a set of CIAB affected features that won't be supported for CIAB sites. Uses the set for availability checker.
  • Temporary evaluates buildConfig == .localDeveloper || buildConfig == .alpha and checks if a site name contains either garden or ciab substrings to determine if a site is CIAB site. This approach will be replaced soon with new API field values. See the tread for more details: p1757415059130279-slack-C03L1NF1EA3

The checker is not yet used - will be used in upcoming PRs.

Testing information

A review and passing CI should be enough. The implemented CIABEligibilityChecker isn't yet used around the app and relies on temporary logic.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.3 milestone Sep 5, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16095-8e285df
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit8e285df
Installation URL7tg8n4kvdcgfg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov marked this pull request as ready for review September 9, 2025 22:15
@itsmeichigo itsmeichigo self-assigned this Sep 10, 2025
itsmeichigo
itsmeichigo approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me. It'd be great if there were unit tests to verify the logic, but I assume you want to leave them until the workarounds are removed.

@RafaelKayumov
Copy link
Contributor Author

RafaelKayumov commented Sep 10, 2025

It'd be great if there were unit tests to verify the logic, but I assume you want to leave them until the workarounds are removed.

Yep. I'll add tests when new API fields are handled.

@RafaelKayumov RafaelKayumov merged commit 581525c into trunk Sep 10, 2025
17 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1268-indentify-CIAB-sites branch September 10, 2025 09:41
@hichamboushaba hichamboushaba mentioned this pull request Sep 15, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

feature: CIAB Mobile Experience type: task An internally driven task.

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelKayumov @wpmobilebot @itsmeichigo