Login: Update root endpoint parsing #16111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
RafaelKayumov
approved these changes
Sep 10, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
LGTM. Works as described. Namespaces arrived as dictionary and were successfully decoded/transformed into an array
| /// This workaround transforms the unexpected dictionary to extract the values in the dictionary. | ||
| let namespaces = siteAPIContainer.failsafeDecodeIfPresent( | ||
| targetType: [String].self, | ||
| forKey: .namespaces, alternativeTypes: [ |
Contributor
There was a problem hiding this comment.
Super nit: I'd put the alternativeTypes: [ on the next line to keep the indentation consistent
itsmeichigo
deleted the
woomob-1315-improve-root-endpoint-parsing-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1315
Description
As part of the Jetpack site improvements project, we are fetching the root endpoint upon app launch and switching sites. This PR adds a similar change with Android in woocommerce/woocommerce-android#14524 PR to support the altered form of the
namespacefield in the response to avoid blocking the app.Additionally, redundant observers are removed upon changes of authentication.
Testing steps
Testing information
In trunk the above steps will lead to an error, but should succeed in this branch.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.