[Woo POS][Local Catalog] Delete data from all grdb tables on logout

[joshheald]

Description

This PR adds a reset function which is called on logout, to delete data from all tables when someone logs out of the app.

Steps to reproduce

Check unit tests pass.

I tested by adding the following to the top of POSCatalogSyncCoordinator.shouldPerformFullSync(for:maxAge:):

try? await grdbManager.databaseConnection.read { db in
            let productCount = try PersistedProduct.fetchCount(db)
            let productImageCount = try PersistedProductImage.fetchCount(db)
            let productAttributeCount = try PersistedProductAttribute.fetchCount(db)
            let variationCount = try PersistedProductVariation.fetchCount(db)
            let variationImageCount = try PersistedProductVariationImage.fetchCount(db)
            let variationAttributeCount = try PersistedProductVariationAttribute.fetchCount(db)

            DDLogInfo("Initially found \(productCount) products, \(productImageCount) product images, " +
                      "\(productAttributeCount) product attributes, \(variationCount) variations, " +
                      "\(variationImageCount) variation images, \(variationAttributeCount) variation attributes")
        }

1. Launch the app and select a POS eligible site
2. Wait until the sync completes and is persisted
3. Log out, and then log back in to the same site
4. When you log in, observe that all the counts logged are 0

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16114-e931cbe
	Version	23.2
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	e931cbe
	Installation URL	34iq10amlp588

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jaclync]

I tested by printing the database path and checking all the tables were non-empty before logout, then became empty after logout.

Hope you don't mind my attempts to fix the unit test failure on test_user_is_logged_out_when_tapping_secondary_button, feel free to change the fix. I was able to reproduce the crash by running the WooCommerceTests suite as a whole (running individual test class passed). The crash was from the fatalError on catalog i1 feature flag disabled while accessing ServiceLocator.grdbManager.

WooCommerce/ServiceLocator.swift:203: Fatal error: GRDBManager accessed when pointOfSaleLocalCatalogi1 feature flag is disabled

because MockStoresManager in WooCommerceTests does not override deauthenticate, it calls DefaultStoresManager.deauthenticate which calls ServiceLocator.grdbManager.

Overriding MockStoresManager.deauthenticate as my first attempt didn't work, because some test cases in WooCommerceTests depend on the DefaultStoresManager.deauthenticate implementation to update the authentication state. As we don't have a good instance to return when the catalog i1 feature is disabled in ServiceLocator.grdbManager, I updated the GRDB reset to only be executed when the same feature flag is enabled.

[jaclync]

nit: how about checking the product/variation images as well?

[joshheald]

I don't think we'll start adding every entity to this function in future, so it seems over the top to add all of them now...

[joshheald]

Hope you don't mind my attempts to fix the unit test failure on test_user_is_logged_out_when_tapping_secondary_button, feel free to change the fix. I was able to reproduce the crash by running the WooCommerceTests suite as a whole (running individual test class passed). The crash was from the fatalError on catalog i1 feature flag disabled while accessing ServiceLocator.grdbManager.

Not at all, makes total sense.

It didn't fail for me locally at all, glad you could reproduce it. I wonder whether my simulator had some leftover feature flag state or something...