Require selected site for `AlamofireNetwork` #16124

itsmeichigo · 2025-09-12T09:01:32Z

Description

This PR removes the default nil value for selectedSite in AlamofireNetwork. It is now required to explicitly decide if network switching should be supported when the network is created.

Network switching is disabled for the following flows:

App widget
Notification extension
Watch app
Jetpack setup
App password generation
App password deletion

For POS flows, since AlamofireNetwork is created separately and there were no clear disagreement on the network switching in p91TBi-dve-p2, I updated all the services to inject selected site and app password support availability to their networks.

Testing steps

For the app, you can follow the test plan in pe5sF9-4Am-p2 if you're interested in testing how the network layer works now.
For POS, I need help with confirming that all features work correctly when the requests are made directly with remote sites via application passwords. To confirm this:
- Log in to a Jetpack site with WPCom credentials.
- Confirm that the app makes direct requests with the site.
- Confirm that all POS features work correctly.

Testing information

Tested alpha build with iPad and card reader M2 and confirmed that POS features use direct requests and payments are successful.
Tested development build with iPhone and confirmed app widget, watch app, Jetpack setup, app password generation and deletion works correctly.

Screenshots

N/A

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

itsmeichigo · 2025-09-12T09:02:46Z

Modules/Sources/Yosemite/PointOfSale/Items/PointOfSaleItemFetchStrategyFactory.swift

    public init(siteID: Int64,
-                credentials: Credentials?) {
+                credentials: Credentials?,
+                selectedSite: AnyPublisher<JetpackSite?, Never>? = nil) {


This has nil as the default value to avoid updating all related unit tests.

wpmobilebot · 2025-09-12T09:11:58Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16124-9462373`
	Version	`23.2`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`9462373`
	Installation URL	22qhveulgmrs0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

…ng-in-pos

dangermattic · 2025-09-16T11:32:23Z

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 23.3. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

itsmeichigo · 2025-09-16T11:35:32Z

@iamgabrielma I see that you're already reviewing this PR. I just added some changes above to inject app password support availability (from remote feature flag and experimental feature flag) to POS's networks. This PR is ready for a new testing round 🙇

iamgabrielma · 2025-09-17T05:17:56Z

@iamgabrielma I see that you're already reviewing this PR. I just added some changes above to inject app password support availability (from remote feature flag and experimental feature flag) to POS's networks. This PR is ready for a new testing round 🙇

Great, thanks for the updates!

I tested all POS flows and I see no issues, when logging into the site via a JP-connected account and enabling application passwords in Settings > Experimental features, all requests appear to be done through direct requests rather than tunneled through the JP proxy 👍

Aside from POS, I smoke tested a bit the app and requests for Blaze and some parts of Analytics (analytics reports) do seem to go through a tunneled request and return a 404 for some endpoints. Is this expected? I believe it is since are routes for gifts and bundles, which I do not have on the test site, but just to be sure.

ie:

https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/215063064/rest-api/?json=true&path=/wc-analytics/reports/bundles%26_method%3Dget&query=%7B%22before%22%3A%222025-09-17T23%3A59%3A59%22%2C%22after%22%3A%222025-09-17T00%3A00%3A00%22%2C%22orderby%22%3A%22items_sold%22%2C%22extended_info%22%3A%22true%22%2C%22per_page%22%3A%225%22%2C%22order%22%3A%22desc%22%7D
https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/215063064/rest-api/?json=true&path=/wc-analytics/reports/bundles/stats%26_method%3Dget&query=%7B%22interval%22%3A%22hour%22%2C%22after%22%3A%222025-09-16T00%3A00%3A00%22%2C%22per_page%22%3A%2224%22%2C%22before%22%3A%222025-09-16T12%3A14%3A36%22%2C%22force_cache_refresh%22%3Atrue%7D
https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/215063064/rest-api/?json=true&path=/wc-analytics/reports/giftcards/used/stats%26_method%3Dget&query=%7B%22before%22%3A%222025-09-16T12%3A14%3A36%22%2C%22force_cache_refresh%22%3Atrue%2C%22interval%22%3A%22hour%22%2C%22per_page%22%3A%2224%22%2C%22after%22%3A%222025-09-16T00%3A00%3A00%22%7D
https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/215063064/rest-api/?json=true&path=/wc-analytics/reports/giftcards/used/stats%26_method%3Dget&query=%7B%22after%22%3A%222025-09-17T00%3A00%3A00%22%2C%22interval%22%3A%22hour%22%2C%22force_cache_refresh%22%3Atrue%2C%22before%22%3A%222025-09-17T23%3A59%3A59%22%2C%22per_page%22%3A%2224%22%7D
https://public-api.wordpress.com/rest/v1.1/jetpack-blogs/215063064/rest-api/?json=true&path=/wc-analytics/reports/bundles/stats%26_method%3Dget&query=%7B%22force_cache_refresh%22%3Atrue%2C%22interval%22%3A%22hour%22%2C%22after%22%3A%222025-09-17T00%3A00%3A00%22%2C%22per_page%22%3A%2224%22%2C%22before%22%3A%222025-09-17T23%3A59%3A59%22%7D

…s alive

itsmeichigo · 2025-09-17T12:06:58Z

Thanks @iamgabrielma for the review!

Aside from POS, I smoke tested a bit the app and requests for Blaze and some parts of Analytics (analytics reports) do seem to go through a tunneled request and return a 404 for some endpoints. Is this expected? I believe it is since are routes for gifts and bundles, which I do not have on the test site, but just to be sure.

Yeah these are expected. Blaze endpoints requires DotCom requests instead of direct requests. Analytics for gifts and bundles analytics fails if you don't have those plugins on your sites, and requests are retried with JP proxy to ensure the failures were not from the direct requests.

I noticed that the app does not switch network requests immediately upon toggling the experimental flag. I added a commit 43e4592 to persist ApplicationPasswordsExperimentState and observe the flag to update the app reactively. Please check again when you have the time 🙏

iamgabrielma · 2025-09-18T10:31:10Z

Works great, toggling the option switches between tunneled/direct requests at runtime 🚀

sentry · 2025-09-25T18:16:13Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ EXC_BREAKPOINT: Fatal error > WooCommerce/WooCrash... in appStore

Make selectedSite param required for AlamofireNetwork init

bc6201c

itsmeichigo added this to the 23.3 milestone Sep 12, 2025

itsmeichigo added type: task An internally driven task. feature: core Core work. See "category: tooling" and "category: architecture" labels Sep 12, 2025

itsmeichigo commented Sep 12, 2025

View reviewed changes

Merge branch 'trunk' into woomob-1332-add-support-for-network-switchi…

d37e1f7

…ng-in-pos

itsmeichigo marked this pull request as ready for review September 12, 2025 10:25

itsmeichigo requested a review from a team September 12, 2025 10:25

iamgabrielma self-assigned this Sep 16, 2025

itsmeichigo added 2 commits September 16, 2025 18:31

Send support availability to AlamofireNetwork

38f00ea

Merge branch 'trunk' into woomob-1332-add-support-for-network-switchi…

d3dd70e

…ng-in-pos

iamgabrielma approved these changes Sep 17, 2025

View reviewed changes

Hold strong ref of ApplicationPasswordsExperimentState to keep stream…

43e4592

…s alive

Ignore periphery warning

9462373

itsmeichigo merged commit 3b620a9 into trunk Sep 18, 2025
14 checks passed

itsmeichigo deleted the woomob-1332-add-support-for-network-switching-in-pos branch September 18, 2025 10:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Require selected site for `AlamofireNetwork` #16124

Require selected site for `AlamofireNetwork` #16124

Uh oh!

itsmeichigo commented Sep 12, 2025 •

edited

Loading

Uh oh!

itsmeichigo Sep 12, 2025

Uh oh!

wpmobilebot commented Sep 12, 2025 •

edited

Loading

Uh oh!

dangermattic commented Sep 16, 2025 •

edited

Loading

Uh oh!

itsmeichigo commented Sep 16, 2025 •

edited

Loading

Uh oh!

iamgabrielma commented Sep 17, 2025

Uh oh!

itsmeichigo commented Sep 17, 2025

Uh oh!

iamgabrielma commented Sep 18, 2025

Uh oh!

Uh oh!

sentry bot commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Require selected site for AlamofireNetwork #16124

Require selected site for AlamofireNetwork #16124

Uh oh!

Conversation

itsmeichigo commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing steps

Testing information

Screenshots

Uh oh!

itsmeichigo Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma commented Sep 17, 2025

Uh oh!

itsmeichigo commented Sep 17, 2025

Uh oh!

iamgabrielma commented Sep 18, 2025

Uh oh!

Uh oh!

sentry bot commented Sep 25, 2025

Issues attributed to commits in this pull request

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Require selected site for `AlamofireNetwork` #16124

Require selected site for `AlamofireNetwork` #16124

itsmeichigo commented Sep 12, 2025 •

edited

Loading

wpmobilebot commented Sep 12, 2025 •

edited

Loading

dangermattic commented Sep 16, 2025 •

edited

Loading

itsmeichigo commented Sep 16, 2025 •

edited

Loading