Remove IAP code and usage #16128

iamgabrielma · 2025-09-15T08:33:19Z

Description

This PR gets rid of the In-App Purchases implementation, as well as partially of the usage of Plan/Domain upgrades through onboarding flow, since some bits of this flow was also using IAP internals. Confirmed with Kiwi that is no longer needed here: p1757921125873789-slack-C03L1NF1EA3, but still needs some extra task to remove the remains that are not coupled, which can be done separately.

There has been no IAP purchases (merchants were not able to purchase since the feature was disabled) or renewals (existing purchases could still be renewed via the app) since April 5th, 2024, so we should be good to remove it. Android counterpart was done in January: pdfdoF-6aJ-p2

Testing information

App should run normally
CI should pass

dangermattic · 2025-09-15T08:34:41Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

iamgabrielma · 2025-09-15T08:38:45Z

Modules/Sources/Networking/Remote/PaymentRemote.swift


 /// WPCOM Payment Endpoints
 ///
+// periphery:ignore


Temporary periphery ignores so I don't have to update PaymentRemote, is possible that we can remove these as well as part of 12401-gh continuation, since are related to domain purchases.

wpmobilebot · 2025-09-15T08:43:34Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16128-20a4859`
	Version	`23.5`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`20a4859`
	Installation URL	5sb7ii6vur6e0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma · 2025-09-15T12:28:13Z

@itsmeichigo looping you in as well for awareness

iamgabrielma · 2025-09-15T12:30:22Z

Modules/Sources/Networking/Remote/FeatureFlagRemote.swift

        switch rawValue {
        case "woo_notification_store_creation_ready":
            self = .storeCreationCompleteNotification
-        case "woo_hardcoded_plan_upgrade_details_milestone_1_are_accurate":


We'll also have to clean the flag from https://public-api.wordpress.com/wpcom/v2/mobile/feature-flags. I haven't tackled this as part of the PR.

iamgabrielma · 2025-09-17T05:55:01Z

👋 @joshheald Feel free to ignore this review during HACK week and team meetup, I'll move the milestone before I forget.

# Conflicts: # WooCommerce/Classes/ViewRelated/Dashboard/Free Trial/StorePlanBannerPresenter.swift # WooCommerce/Classes/ViewRelated/Upgrades/CurrentPlanDetailsView.swift # WooCommerce/Classes/ViewRelated/Upgrades/UpgradeWaitingView.swift # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

iamgabrielma · 2025-09-29T07:38:36Z

Additionally there are 2 subscription groups (9 subscriptions total, production and test) that we can remove from ASC, as well as the 2 .storekit config files from the Woo target. I'll clean these after we've wrapped this one up.

joshheald · 2025-10-06T16:20:47Z

I've not forgotten about this, will get to it in the next day or two

joshheald · 2025-10-10T15:46:52Z

Additionally there are 2 subscription groups (9 subscriptions total, production and test) that we can remove from ASC, as well as the 2 .storekit config files from the Woo target. I'll clean these after we've wrapped this one up.

I don't think you can ever remove approved subscriptions from ASC, just mark them as not available for sale, which should be done already

joshheald

Well done. Always good to see a summer's worth of work deleted 😂

There may be some stuff you can remove from PaymentAction/Store... worth checking with Kiwi whether we actually do the check for whether it's a free trial or not and show publishing stuff as part of the onboarding. It smells like Woo Express code to me. Another PR might be best though

# Conflicts: # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

iamgabrielma · 2025-10-13T07:06:53Z

Thanks for the review!

Always good to see a summer's worth of work deleted 😂

😂

There may be some stuff you can remove from PaymentAction/Store... worth checking with Kiwi whether we actually do the check for whether it's a free trial or not and show publishing stuff as part of the onboarding. It smells like Woo Express code to me. Another PR might be best though

Yes, there are still bits of IAP/WooExpress/Domains here and there that wasn't coupled with the rest of IAP, I'll clean up the other bits on a separate PR so this one doesn't get even bigger.

wpmobilebot · 2025-10-17T04:52:05Z

Version 23.5 has now entered code-freeze, so the milestone of this PR has been updated to 23.6.

Does not compile after modularization due to error: Build input files cannot be found. 4 files still appear referenced in the woo target build phase despite being deleted, so I’ve removed them manually.

iamgabrielma added 6 commits September 15, 2025 14:03

remove upgrades entry point

ea6ff97

remove upgrades-subscriptions views

942a917

remove iap models

85f4a02

remove IAP action dispatcher

5ba8b96

remove IAP remotes and tests

12a6cc9

periphery cleanup

a88b60d

iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Sep 15, 2025

iamgabrielma added this to the 23.3 milestone Sep 15, 2025

iamgabrielma commented Sep 15, 2025

View reviewed changes

update note

430f5f8

iamgabrielma added the category: tracks Related to analytics, including Tracks Events. label Sep 15, 2025

iamgabrielma marked this pull request as ready for review September 15, 2025 11:56

iamgabrielma requested a review from joshheald September 15, 2025 12:27

iamgabrielma commented Sep 15, 2025

View reviewed changes

iamgabrielma modified the milestones: 23.3, 23.4 Sep 17, 2025

iamgabrielma and others added 2 commits September 17, 2025 12:55

Merge branch 'trunk' into task/WOOMOB-1290-remove-IAP-usage

b4ead71

Merge branch 'trunk' into task/WOOMOB-1290-remove-IAP-usage

320dcd8

iamgabrielma modified the milestones: 23.4, 23.5 Oct 3, 2025

joshheald approved these changes Oct 10, 2025

View reviewed changes

Merge branch 'trunk' into task/WOOMOB-1290-remove-IAP-usage

0ce2260

# Conflicts: # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

wpmobilebot modified the milestones: 23.5, 23.6 Oct 17, 2025

iamgabrielma added 2 commits October 17, 2025 16:01

Merge branch 'trunk' into task/WOOMOB-1290-remove-IAP-usage

e234ea5

remove references from deleted files from woo build phase

20a4859

Does not compile after modularization due to error: Build input files cannot be found. 4 files still appear referenced in the woo target build phase despite being deleted, so I’ve removed them manually.

iamgabrielma merged commit 2474539 into trunk Oct 17, 2025
13 checks passed

iamgabrielma deleted the task/WOOMOB-1290-remove-IAP-usage branch October 17, 2025 09:52

Remove IAP code and usage #16128

Remove IAP code and usage #16128

Uh oh!

Conversation

iamgabrielma commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

Uh oh!

dangermattic commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma commented Sep 15, 2025

Uh oh!

iamgabrielma Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma commented Sep 17, 2025

Uh oh!

iamgabrielma commented Sep 29, 2025

Uh oh!

joshheald commented Oct 6, 2025

Uh oh!

joshheald commented Oct 10, 2025

Uh oh!

joshheald left a comment

Choose a reason for hiding this comment

Uh oh!

iamgabrielma commented Oct 13, 2025

Uh oh!

wpmobilebot commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iamgabrielma commented Sep 15, 2025 •

edited

Loading

dangermattic commented Sep 15, 2025 •

edited

Loading

iamgabrielma Sep 15, 2025 •

edited

Loading

wpmobilebot commented Sep 15, 2025 •

edited

Loading